-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update large record report warning #429
Conversation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-reporting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-reporting/backport-2.x
# Create a new branch
git switch --create backport/backport-429-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 757d2484aa99927ec2768203aed829f1a8afc4ac
# Push it to GitHub
git push --set-upstream origin backport/backport-429-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-reporting/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-reporting/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-reporting/backport-2.17
# Create a new branch
git switch --create backport/backport-429-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 757d2484aa99927ec2768203aed829f1a8afc4ac
# Push it to GitHub
git push --set-upstream origin backport/backport-429-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-reporting/backport-2.17 Then, create a pull request where the |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
* [Feature] Add the ability to configure record limit/count from the UI (#395) * feat(components/report-settings): add field for variable record limits Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> * fix(components/report-settings): set type for event target Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> * feat(components/report-settings): load existing record limit in edit mode Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> * feat(components/report-definition-details): show record limit on report definition details page Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> * feat(components/report-definition-details): omit record limit for non saved search sources Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> * feat(components/report-details): show record limit on report details page Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> * tests(cypress): add `force: true` to name input Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> * tests(jest/snapshots): update snapshots Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> * feat(components/report-settings): add proper i18n label for record limit input Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> * Update release notes Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add potential OOM warning for large record limits Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make memory warning more conservative based on original limit Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> * Fix merge conflict markers Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update large record report warning (#429) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Merge 2.x Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Károly Szakály <karoly.szakaly2000@gmail.com> Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Co-authored-by: Károly Szakály <karoly.szakaly2000@gmail.com>
Description
Updating the UX on the warning per UX feedback
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.