Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Update qs, minimatch and yaml versions #65

Merged
merged 21 commits into from
May 1, 2023

Conversation

rupal-bq
Copy link
Member

@rupal-bq rupal-bq commented Apr 27, 2023

Description

error yaml@2.2.2: The engine "node" is incompatible with this module. Expected version ">= 14". Got "10.24.1"

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rupal-bq rupal-bq mentioned this pull request Apr 27, 2023
6 tasks
Ubuntu and others added 4 commits April 27, 2023 22:46
yaml@2.2.2 does not support node v10.24.1

This reverts commit e8bb51e.

Signed-off-by: Ubuntu <ubuntu@ip-172-31-49-94.us-west-2.compute.internal>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Ubuntu <ubuntu@ip-172-31-49-94.us-west-2.compute.internal>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Ubuntu <ubuntu@ip-172-31-49-94.us-west-2.compute.internal>
* Add github workflows

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix env name

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Ubuntu <ubuntu@ip-172-31-49-94.us-west-2.compute.internal>
@rupal-bq
Copy link
Member Author

rupal-bq commented Apr 27, 2023

CI failing with

ValueError: invalid mode: 'rU' while trying to load binding.gyp
gyp ERR! configure error 
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/Users/runner/work/dashboards-query-workbench/dashboards-query-workbench/OpenSearch-Dashboards/node_modules/node-gyp/lib/configure.js:350:16)
gyp ERR! stack     at ChildProcess.emit (events.js:198:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
gyp ERR! System Darwin 21.6.0

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (1.3@8856e45). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@          Coverage Diff           @@
##             1.3      #65   +/-   ##
======================================
  Coverage       ?   62.91%           
======================================
  Files          ?       10           
  Lines          ?      658           
  Branches       ?      119           
======================================
  Hits           ?      414           
  Misses         ?      191           
  Partials       ?       53           
Flag Coverage Δ
dashboards-query-workbench 62.91% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
…ch into 1.3-qs

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
This reverts commit 377e91b.

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
This reverts commit 85e22c1.

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
@rupal-bq rupal-bq merged commit 7f11aa7 into opensearch-project:1.3 May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants