Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.8] Backport/backport 588 to 2.8 #596

Merged

Conversation

mengweieric
Copy link
Collaborator

(cherry picked from commit a85b716)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…erelease-code-cleanup

(cherry picked from commit a85b716)
@mengweieric mengweieric changed the title Merge pull request #588 from mengweieric/feature/prerelease-code-cleanup [BACKPORT 2.8]Merge pull request #588 from mengweieric/feature/prerelease-code-cleanup Jun 30, 2023
@mengweieric mengweieric changed the title [BACKPORT 2.8]Merge pull request #588 from mengweieric/feature/prerelease-code-cleanup [Backport 2.8] Backport/backport 588 to 2.7 Jun 30, 2023
@mengweieric mengweieric changed the title [Backport 2.8] Backport/backport 588 to 2.7 [Backport 2.8] Backport/backport 588 to 2.8 Jun 30, 2023
Signed-off-by: Eric Wei <menwe@amazon.com>
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #596 (88676a5) into 2.8 (673200d) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.8     #596      +/-   ##
==========================================
- Coverage   42.73%   42.66%   -0.08%     
==========================================
  Files         299      294       -5     
  Lines       17811    17782      -29     
  Branches     4360     4402      +42     
==========================================
- Hits         7612     7587      -25     
+ Misses      10158     9664     -494     
- Partials       41      531     +490     
Flag Coverage Δ
dashboards-observability 42.66% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 93 files with indirect coverage changes

@mengweieric mengweieric merged commit d31dde0 into opensearch-project:2.8 Jul 5, 2023
5 of 8 checks passed
@mengweieric mengweieric deleted the backport/backport-588-to-2.8 branch July 5, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants