Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.16] Fix direct url load for trace analytics #2027

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Aug 1, 2024

Description

Loading trace analytics directly via URL defaults to services page even when /traces path is added in the URL.
Main PR: #2024

Example:

http://host:port/app/observability-traces#/services -> Loads services as expected.
http://host:port/app/observability-traces#/traces -> Doesn't load traces page, rather loads services page. 

Issues Resolved

Fixes the default route path when URL has the required hash and overrides the one in props.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 3c7c388)
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 438c7c8)
@ps48 ps48 merged commit ff972c3 into opensearch-project:2.16 Aug 1, 2024
13 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants