Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Getting Started update patterns created #2016

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Jul 31, 2024

Description

Update ndjson so workflows matches patterns created
Otel:
Screenshot 2024-07-31 at 1 26 11 PM
Before change:
Screenshot 2024-07-31 at 1 27 35 PM

After change: Removed otel-metrics*
Screenshot 2024-07-31 at 1 26 30 PM

CSV:
Screenshot 2024-07-31 at 1 28 17 PM
Before change:
Screenshot 2024-07-31 at 1 29 05 PM

After change: Renamed to match logs-*
Screenshot 2024-07-31 at 1 28 43 PM

The rest of the workflows were matching and did not need correction.

Known test failure
"Summary of all failing tests
FAIL public/components/event_analytics/explorer/query_assist/tests/input.test.tsx (8.632 s)
● spec › should display toast for generate errors"

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Adam Tackett <tackadam@amazon.com>
@ps48 ps48 merged commit 6094e4c into opensearch-project:main Jul 31, 2024
12 of 26 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 31, 2024
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
(cherry picked from commit 6094e4c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-main main
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-main
# Create a new branch
git switch --create backport/backport-2016-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6094e4ca0ddc10989a9b83151e03837c2751f2e7
# Push it to GitHub
git push --set-upstream origin backport/backport-2016-to-main
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-2016-to-main.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 31, 2024
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
(cherry picked from commit 6094e4c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB pushed a commit that referenced this pull request Jul 31, 2024
(cherry picked from commit 6094e4c)

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
YANG-DB pushed a commit that referenced this pull request Jul 31, 2024
(cherry picked from commit 6094e4c)

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants