Fix Observability CI workflow checks (#2046) (#2054)

* add job scheduler to observability CI Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update workflow for integ tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove datasources test Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * exclude localhost links from link checker Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update links for link checker Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 61e6012)
opensearch-project · Aug 12, 2024 · 71f4a73 · 71f4a73
1 parent 10165d0
commit 71f4a73
Show file tree

Hide file tree

Showing 9 changed files with 78 additions and 104 deletions.
diff --git a/.cypress/integration/datasources_test/datasources_basic_ui.spec.js b/.cypress/integration/datasources_test/datasources_basic_ui.spec.js
diff --git a/.github/workflows/ftr-e2e-dashboards-observability-test.yml b/.github/workflows/ftr-e2e-dashboards-observability-test.yml
@@ -4,11 +4,11 @@ on:
   push:
   pull_request:
   schedule:
-    - cron: '0 0 * * *'
+    - cron: "0 0 * * *"
 
 env:
   PLUGIN_NAME: dashboards-observability
-  OPENSEARCH_DASHBOARDS_VERSION: '2.x'
+  OPENSEARCH_DASHBOARDS_VERSION: "2.x"
 
 jobs:
   tests:
@@ -31,12 +31,12 @@ jobs:
       - name: Set up Java 11
         uses: actions/setup-java@v3
         with:
-          distribution: 'corretto'
-          java-version: '11'
+          distribution: "corretto"
+          java-version: "11"
 
       - name: Checkout Branch
         uses: actions/checkout@v3
-  
+
       - name: Set env
         run: |
           opensearch_version=$(node -p "require('./opensearch_dashboards.json').opensearchDashboardsVersion")
@@ -45,6 +45,13 @@ jobs:
           echo "OPENSEARCH_PLUGIN_VERSION=$plugin_version" >> $GITHUB_ENV
         shell: bash
 
+      - name: Download Job Scheduler artifact
+        uses: suisei-cn/actions-download-file@v1.4.0
+        with:
+          url: https://aws.oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=org.opensearch.plugin&a=opensearch-job-scheduler&v=${{ env.OPENSEARCH_PLUGIN_VERSION }}-SNAPSHOT&p=zip
+          target: plugin-artifacts/
+          filename: opensearch-job-scheduler.zip
+
       - name: Download observability artifact
         uses: suisei-cn/actions-download-file@v1.4.0
         with:
@@ -70,6 +77,11 @@ jobs:
           rm -f opensearch-*.tar.gz
         shell: bash
 
+      - name: Install job scheduler plugin
+        run: |
+          /bin/bash -c "yes | ./opensearch-${{ env.OPENSEARCH_VERSION }}-SNAPSHOT/bin/opensearch-plugin install file:$(pwd)/plugin-artifacts/opensearch-job-scheduler.zip"
+        shell: bash
+
       - name: Install observability plugin
         run: |
           /bin/bash -c "yes | ./opensearch-${{ env.OPENSEARCH_VERSION }}-SNAPSHOT/bin/opensearch-plugin install file:$(pwd)/plugin-artifacts/observability.zip"
@@ -107,7 +119,7 @@ jobs:
         uses: actions/setup-node@v1
         with:
           node-version: ${{ steps.versions_step.outputs.node_version }}
-          registry-url: 'https://registry.npmjs.org'
+          registry-url: "https://registry.npmjs.org"
 
       - name: Install correct yarn version for OpenSearch Dashboards
         run: |
@@ -125,7 +137,7 @@ jobs:
           cd OpenSearch-Dashboards
           nohup yarn start --no-base-path --no-watch | tee dashboard.log &
 
-      - name : Check If OpenSearch Dashboards Is Ready
+      - name: Check If OpenSearch Dashboards Is Ready
         if: ${{ runner.os == 'Linux' }}
         run: |
           cd ./OpenSearch-Dashboards
@@ -143,7 +155,7 @@ jobs:
           repository: opensearch-project/opensearch-dashboards-functional-test
           ref: ${{ env.OPENSEARCH_DASHBOARDS_VERSION }}
           fetch-depth: 0
-  
+
       - name: Install Cypress
         run: |
           npm install cypress --save-dev

diff --git a/.github/workflows/integration-tests-workflow.yml b/.github/workflows/integration-tests-workflow.yml
@@ -4,7 +4,7 @@ on: [pull_request, push]
 
 env:
   PLUGIN_NAME: dashboards-observability
-  OPENSEARCH_DASHBOARDS_VERSION: '2.x'
+  OPENSEARCH_DASHBOARDS_VERSION: "2.x"
 
 jobs:
   tests:
@@ -24,7 +24,6 @@ jobs:
         testgroups:
           [
             app_analytics_test,
-            datasources_test,
             event_analytics_test,
             integrations_test,
             metrics_analytics_test,
@@ -41,8 +40,8 @@ jobs:
       - name: Set up Java 11
         uses: actions/setup-java@v3
         with:
-          distribution: 'corretto'
-          java-version: '11'
+          distribution: "corretto"
+          java-version: "11"
 
       - name: Checkout Branch
         uses: actions/checkout@v3
@@ -55,6 +54,13 @@ jobs:
           echo "OPENSEARCH_PLUGIN_VERSION=$plugin_version" >> $GITHUB_ENV
         shell: bash
 
+      - name: Download Job Scheduler artifact
+        uses: suisei-cn/actions-download-file@v1.4.0
+        with:
+          url: https://aws.oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=org.opensearch.plugin&a=opensearch-job-scheduler&v=${{ env.OPENSEARCH_PLUGIN_VERSION }}-SNAPSHOT&p=zip
+          target: plugin-artifacts/
+          filename: opensearch-job-scheduler.zip
+
       - name: Download observability artifact
         uses: suisei-cn/actions-download-file@v1.4.0
         with:
@@ -80,6 +86,11 @@ jobs:
           rm -f opensearch-*.tar.gz
         shell: bash
 
+      - name: Install job scheduler plugin
+        run: |
+          /bin/bash -c "yes | ./opensearch-${{ env.OPENSEARCH_VERSION }}-SNAPSHOT/bin/opensearch-plugin install file:$(pwd)/plugin-artifacts/opensearch-job-scheduler.zip"
+        shell: bash
+
       - name: Install observability plugin
         run: |
           /bin/bash -c "yes | ./opensearch-${{ env.OPENSEARCH_VERSION }}-SNAPSHOT/bin/opensearch-plugin install file:$(pwd)/plugin-artifacts/observability.zip"
@@ -117,7 +128,7 @@ jobs:
         uses: actions/setup-node@v1
         with:
           node-version: ${{ steps.versions_step.outputs.node_version }}
-          registry-url: 'https://registry.npmjs.org'
+          registry-url: "https://registry.npmjs.org"
 
       - name: Configure OpenSearch Dashboards
         run: |
@@ -189,4 +200,4 @@ jobs:
         if: always()
         with:
           name: cypress-videos-${{ matrix.os }}
-          path: OpenSearch-Dashboards/plugins/dashboards-observability/.cypress/videos
+          path: OpenSearch-Dashboards/plugins/dashboards-observability/.cypress/videos
diff --git a/.github/workflows/link-checker.yml b/.github/workflows/link-checker.yml
@@ -1,13 +1,12 @@
 name: Link Checker
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
 
 jobs:
   linkchecker:
-
     runs-on: ubuntu-latest
 
     steps:
@@ -16,9 +15,8 @@ jobs:
         id: lychee
         uses: lycheeverse/lychee-action@master
         with:
-          args: --accept=200,403,429  "./**/*.html" "./**/*.md" "./**/*.txt"
+          args: --accept=200,403,429  "./**/*.html" "./**/*.md" "./**/*.txt" --exclude "http://localhost" --exclude "https://localhost"
         env:
           GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
       - name: Fail if there were link errors
         run: exit ${{ steps.lychee.outputs.exit_code }}
-
diff --git a/..._started/getting_started_artifacts/otel-services/assets/getting-started-demo-1.0.0.ndjson b/..._started/getting_started_artifacts/otel-services/assets/getting-started-demo-1.0.0.ndjson
diff --git a/...g_started/getting_started_artifacts/otel-services/assets/otel-index-patterns-1.0.0.ndjson b/...g_started/getting_started_artifacts/otel-services/assets/otel-index-patterns-1.0.0.ndjson