feat: update backend to support MDS #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raintygao
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
wanglam
as code owners
wanglam
reviewed
May 28, 2024
| @@ -123,16 +146,20 @@ const feedbackRoute = { | |||
| body: schema.object({ | |||
| satisfaction: schema.boolean(), | |||
| }), | |||
| query: schema.object({ | |||
| dataSourceId: schema.maybe(schema.string()), | |||
There was a problem hiding this comment.
Shall we add some UT for dataSourceId query passed?
There was a problem hiding this comment.
We could add UT for data source specifically, for now this PR is depended by other PRs, right?
There was a problem hiding this comment.
Do you mean will be added in the following PRs?
There was a problem hiding this comment.
I remember that you wanted this PR being merged ASAP, if not, we could try to add tests in this PR to make this fully.
There was a problem hiding this comment.
I think you can added them first. At least we need to verify the route handler called getOpenSearchClientTransport with passed data source id.
wanglam
reviewed
May 28, 2024
wanglam
approved these changes
May 29, 2024
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
reviewed
May 30, 2024
SuZhou-Joe
reviewed
May 30, 2024
SuZhou-Joe
approved these changes
May 30, 2024
Signed-off-by: tygao <tygao@amazon.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-assistant/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-assistant/backport-2.x
# Create a new branch
git switch --create backport/backport-190-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0d6ce86b742b50b3a0cc0cd8a1a609ced1d59895
# Push it to GitHub
git push --set-upstream origin backport/backport-190-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-assistant/backport-2.xThen, create a pull request where the |
raintygao
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
* init MDS Signed-off-by: tygao <tygao@amazon.com> * update backend to support mds Signed-off-by: tygao <tygao@amazon.com> * remove DSM in required plugins Signed-off-by: tygao <tygao@amazon.com> * doc: update changelog Signed-off-by: tygao <tygao@amazon.com> * test: update tests Signed-off-by: tygao <tygao@amazon.com> * update mock context Signed-off-by: tygao <tygao@amazon.com> * update core context mock Signed-off-by: tygao <tygao@amazon.com> * test: add tests for chat route Signed-off-by: tygao <tygao@amazon.com> * use await and update tests Signed-off-by: tygao <tygao@amazon.com> * Fix unit tests after getDataSourceQuery change Signed-off-by: Lin Wang <wonglam@amazon.com> * remove useless DSM calling in flyout Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 0d6ce86) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
raintygao
added a commit
that referenced
this pull request
Jun 3, 2024
* init MDS Signed-off-by: tygao <tygao@amazon.com> * update backend to support mds Signed-off-by: tygao <tygao@amazon.com> * remove DSM in required plugins Signed-off-by: tygao <tygao@amazon.com> * doc: update changelog Signed-off-by: tygao <tygao@amazon.com> * test: update tests Signed-off-by: tygao <tygao@amazon.com> * update mock context Signed-off-by: tygao <tygao@amazon.com> * update core context mock Signed-off-by: tygao <tygao@amazon.com> * test: add tests for chat route Signed-off-by: tygao <tygao@amazon.com> * use await and update tests Signed-off-by: tygao <tygao@amazon.com> * Fix unit tests after getDataSourceQuery change Signed-off-by: Lin Wang <wonglam@amazon.com> * remove useless DSM calling in flyout Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 0d6ce86) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: tygao <tygao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There will be another PR about integrating in frontend and depend on opensearch-project/OpenSearch-Dashboards#6827
Issue resolved
#192
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.