Fixes base64 encoded hardcoded admin credentials #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshitChanpura
requested review from
krishna-ggk,
ankitkala,
saikaranam-amazon,
soosinha,
gbbafna and
monusingh-1
as code owners
DarshitChanpura
added
backport 2.x
v2.12.0
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
fix-hardcoded-base64creds
branch
from
5f5e981
to
6c0edad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1331 +/- ##
============================================
+ Coverage 76.36% 76.45% +0.08%
+ Complexity 1050 1045 -5
============================================
Files 141 141
Lines 4782 4782
Branches 526 526
============================================
+ Hits 3652 3656 +4
+ Misses 776 773 -3
+ Partials 354 353 -1 ☔ View full report in Codecov by Sentry. |
bbarani
previously approved these changes
Feb 14, 2024
prudhvigodithi
previously approved these changes
Feb 14, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
dismissed stale reviews from prudhvigodithi and bbarani
via
5a98399
monusingh-1
approved these changes
Feb 15, 2024
bbarani
approved these changes
Feb 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Fixes base64 encoded hardcoded admin credentials Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes broken integTest task Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 74dfcd1)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Fixes base64 encoded hardcoded admin credentials Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes broken integTest task Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 74dfcd1)
monusingh-1
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Fixes base64 encoded hardcoded admin credentials Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes broken integTest task Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 74dfcd1) Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
monusingh-1
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Fixes base64 encoded hardcoded admin credentials Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes broken integTest task Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 74dfcd1) Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
skumarp7
pushed a commit
to nokia/opensearch-project-cross-cluster-replication
that referenced
this pull request
Jul 22, 2024
…1331) (opensearch-project#1332) * Fixes base64 encoded hardcoded admin credentials Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes broken integTest task Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 74dfcd1) Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See these comments:
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.