Addition of NotificationEvent to SendNotificationResponse and Removal of NotificationID #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityaj1107
changed the title
added 2 commits
April 7, 2022 12:46
Addition of NotificationEventDoc and Removal of NotificationEventInfo Addition of NotificationEventDocTests Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com>
Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com>
6 tasks
adityaj1107
changed the title
qreshi
approved these changes
Apr 7, 2022
qreshi
changed the title
qreshi
changed the title
lezzago
approved these changes
Apr 7, 2022
zelinh
pushed a commit
that referenced
this pull request
Aug 18, 2022
… of NotificationID (#156) * Removal of NotificationEvent Request, Response , Search Results Addition of NotificationEventDoc and Removal of NotificationEventInfo Addition of NotificationEventDocTests Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com> * Removing NotificationEventDoc and NotificationEventDocTests Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com> Co-authored-by: Jindal <aditjind@88665a235f8e.ant.amazon.com> Signed-off-by: Zelin Hao <zelinhao@amazon.com>
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
… of NotificationID (opensearch-project#156) * Removal of NotificationEvent Request, Response , Search Results Addition of NotificationEventDoc and Removal of NotificationEventInfo Addition of NotificationEventDocTests Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com> * Removing NotificationEventDoc and NotificationEventDocTests Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com> Co-authored-by: Jindal <aditjind@88665a235f8e.ant.amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
notificationIDfromSendNotificationAPI response and add NotificationEvent to theSendNotificationAPIIssues Resolved
opensearch-project/notifications#393
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.