Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default opensearch version to 2.0.0-alpha1-SNAPSHOT #146

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Change default opensearch version to 2.0.0-alpha1-SNAPSHOT

Issues Resolved

Part of opensearch-project/opensearch-build#1632

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Contributor

@dbbaughe dbbaughe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the long term solution for this? Or should it remain 2.0.0-SNAPSHOT and instead the build infrastructure should pass in the qualifier during the build of common utils so it can go and pull the alpha1 snapshots instead?

@peterzhuamazon
Copy link
Member Author

@dbbaughe this value is default means every new release you guys should change it for your checks.
As for infra we will pass the opensearch.version directly thus not an issue for us.

@dbbaughe
Copy link
Contributor

@peterzhuamazon Yes, what I mean is we will need to now change this back in the future to 2.0.0-SNAPSHOT. If we had kept this as 2.0.0-SNAPSHOT instead, would it not have been possible for infra to pass the qualifier themselves during the build of this project instead of hardcoding the qualifier?

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Mar 28, 2022

@peterzhuamazon Yes, what I mean is we will need to now change this back in the future to 2.0.0-SNAPSHOT. If we had kept this as 2.0.0-SNAPSHOT instead, would it not have been possible for infra to pass the qualifier themselves during the build of this project instead of hardcoding the qualifier?

It would not block infra in anyway in our distribution pipeline if you keep 2.0.0-alpha1-SNAPSHOT as infra will pass 2.0.0 or 2.0.0-SNAPSHOT in infra jenkins anyway.

We will override -Dopensearch.version param in our build.

@peterzhuamazon peterzhuamazon merged commit f2f57e5 into opensearch-project:main Mar 28, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-qualifier-default branch March 28, 2022 20:56
@dbbaughe
Copy link
Contributor

@peterzhuamazon Yes, what I mean is we will need to now change this back in the future to 2.0.0-SNAPSHOT. If we had kept this as 2.0.0-SNAPSHOT instead, would it not have been possible for infra to pass the qualifier themselves during the build of this project instead of hardcoding the qualifier?

It would not block infra in anyway in our distribution pipeline if you keep 2.0.0-alpha1-SNAPSHOT as infra will pass 2.0.0 or 2.0.0-SNAPSHOT in infra jenkins anyway.

We will override -Dopensearch.version param in our build.

Got it, so sounds like this change wasn't really needed then?

@peterzhuamazon
Copy link
Member Author

@peterzhuamazon Yes, what I mean is we will need to now change this back in the future to 2.0.0-SNAPSHOT. If we had kept this as 2.0.0-SNAPSHOT instead, would it not have been possible for infra to pass the qualifier themselves during the build of this project instead of hardcoding the qualifier?

It would not block infra in anyway in our distribution pipeline if you keep 2.0.0-alpha1-SNAPSHOT as infra will pass 2.0.0 or 2.0.0-SNAPSHOT in infra jenkins anyway.
We will override -Dopensearch.version param in our build.

Got it, so sounds like this change wasn't really needed then?

It is needed, because your CI is still pointing to the weeks old 2.0.0-SNAPSHOT instead of 2.0.0-alpha1-SNAPSHOT.

@peterzhuamazon
Copy link
Member Author

It is possible when we reach 2.0.0GA there are new core changes so suggest you still change default to 2.0.0-SNAPSHOT when it comes for your CI to be pointed to correct snapshot.

zelinh pushed a commit that referenced this pull request Aug 18, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants