-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default opensearch version to 2.0.0-alpha1-SNAPSHOT #146
Change default opensearch version to 2.0.0-alpha1-SNAPSHOT #146
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the long term solution for this? Or should it remain 2.0.0-SNAPSHOT and instead the build infrastructure should pass in the qualifier during the build of common utils so it can go and pull the alpha1 snapshots instead?
@dbbaughe this value is default means every new release you guys should change it for your checks. |
@peterzhuamazon Yes, what I mean is we will need to now change this back in the future to 2.0.0-SNAPSHOT. If we had kept this as 2.0.0-SNAPSHOT instead, would it not have been possible for infra to pass the qualifier themselves during the build of this project instead of hardcoding the qualifier? |
It would not block infra in anyway in our distribution pipeline if you keep 2.0.0-alpha1-SNAPSHOT as infra will pass We will override -Dopensearch.version param in our build. |
Got it, so sounds like this change wasn't really needed then? |
It is needed, because your CI is still pointing to the weeks old 2.0.0-SNAPSHOT instead of 2.0.0-alpha1-SNAPSHOT. |
It is possible when we reach 2.0.0GA there are new core changes so suggest you still change default to 2.0.0-SNAPSHOT when it comes for your CI to be pointed to correct snapshot. |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Zelin Hao <zelinhao@amazon.com>
…h-project#146) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Change default opensearch version to 2.0.0-alpha1-SNAPSHOT
Issues Resolved
Part of opensearch-project/opensearch-build#1632
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.