Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment to 1.3.2 #484

Closed
wants to merge 2 commits into from

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Apr 1, 2022

Description

Coming from opensearch-project/opensearch-build#1805 post release activity.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Rohidas Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Rohidas Gaikawad <gaiksaya@amazon.com>
@amitgalitz
Copy link
Member

lets merge this in first #475? @ohltyler @ylwu-amzn, makes sense to merge this into 1.3 and backport to 1.x today? I see that https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.2/latest/linux/x64/builds/opensearch/plugins/opensearch-job-scheduler-1.3.2.0.zip is already ready so that could make 1.3.2 first version bump with no zip upgrade?

@ohltyler
Copy link
Member

ohltyler commented Apr 1, 2022

lets merge this in first #475? @ohltyler @ylwu-amzn, makes sense to merge this into 1.3 and backport to 1.x today? I see that https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.2/latest/linux/x64/builds/opensearch/plugins/opensearch-job-scheduler-1.3.2.0.zip is already ready so that could make 1.3.2 first version bump with no zip upgrade?

Sounds good to me. Assuming you just mean backport #475 to 1.x and confirm it picks up a 1.4 job-scheduler zip? But I don't see a 1.4 zip available yet, seems there's some infra issues related to that (ref: ml-commons PR). URL doesn't resolve either: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.4.0/1389/linux/x64/builds/opensearch/plugins/opensearch-job-scheduler-1.4.0.0.zip

@ohltyler
Copy link
Member

ohltyler commented Apr 1, 2022

^ we can have a separate discussion about that in the specific PR though. I'm ok to merge #475 first to 1.3, then @gaiksaya can rebase and remove the manual built zip as part of this PR - or we can handle separately too, either way :)

@amitgalitz
Copy link
Member

Closing and merging since we made new changes to 1.3 #485

@amitgalitz amitgalitz closed this Apr 1, 2022
@gaiksaya gaiksaya deleted the increment-to-1.3.2 branch April 5, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants