Resolve Moment.js CVE Issue #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses a CVE related to our use of a version of moment.js that is below 2.29.2. Modified as per the reference PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1931/files Testing done: 1. Executed an end-to-end test to ensure that we can still create and run a detector with the updated moment.js version. Signed-off-by: Kaituo Li <kaituo@amazon.com>
amitgalitz
approved these changes
Jul 10, 2023
jackiehanyang
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a CVE related to our use of a version of moment.js that is below 2.29.2.
Modified as per the reference PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1931/files
Testing done:
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.