fixing vis eligibility

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
opensearch-project · Jun 28, 2023 · fb3f590 · fb3f590
1 parent 01883d2
commit fb3f590
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/public/action/ad_dashboard_action.tsx b/public/action/ad_dashboard_action.tsx
@@ -16,6 +16,7 @@ import { isReferenceOrValueEmbeddable } from '../../../../src/plugins/embeddable
 import { EuiIconType } from '@elastic/eui/src/components/icon/icon';
 import { VisualizeEmbeddable } from '../../../../src/plugins/visualizations/public';
 import { isEligibleForVisLayers } from '../../../../src/plugins/vis_augmenter/public';
+import { getUISettings } from '../services';
 
 export const ACTION_AD = 'ad';
 
@@ -62,9 +63,10 @@ export const createADAction = ({
       const vis = (embeddable as VisualizeEmbeddable).vis;
       return Boolean(
         embeddable.parent &&
+          embeddable.getInput()?.viewMode === 'view' &&
           isDashboard(embeddable.parent) &&
           vis !== undefined &&
-          isEligibleForVisLayers(vis)
+          isEligibleForVisLayers(vis, getUISettings())
       );
     },
     execute: async ({ embeddable }: ActionContext) => {

diff --git a/...ponents/FeatureAnywhereContextMenu/AssociatedDetectors/containers/AssociatedDetectors.tsx b/...ponents/FeatureAnywhereContextMenu/AssociatedDetectors/containers/AssociatedDetectors.tsx
@@ -281,7 +281,13 @@ function AssociatedDetectors({ embeddable, closeFlyout, setMode }) {
   };
   return (
     <div className="associated-detectors">
-      <EuiFlyout style={{ maxWidth: '740px' }} ownFocus size="m" paddingSize="m" onClose={closeFlyout}>
+      <EuiFlyout
+        style={{ maxWidth: '740px' }}
+        ownFocus
+        size="m"
+        paddingSize="m"
+        onClose={closeFlyout}
+      >
         <EuiFlyoutHeader hasBorder>
           <EuiTitle>
             <h2 id="associated-detectors__title">

diff --git a/public/plugin.ts b/public/plugin.ts
@@ -83,11 +83,7 @@ export class AnomalyDetectionOpenSearchDashboardsPlugin
       },
     });
 
-    // // set embeddable plugin for feature anywhere create flyout
-    // setEmbeddable(embeddable);
-
-    // // set vis argumenter loader for feature anywhere associated flyout
-    // setSavedFeatureAnywhereLoader(visAugmenter.savedAugmentVisLoader);
+    setUISettings(core.uiSettings);
 
     // Set the HTTP client so it can be pulled into expression fns to make
     // direct server-side calls