Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to run bwc tests against bundle #735

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Jan 5, 2023

Signed-off-by: Zelin Hao zelinhao@amazon.com

Description

Add option to run BWC tests in distribution level, which is running tests in the test cluster with latest distribution bundle installed and all plugins (included in the latest manifest) present.

The command to run BWC tests in distribution level would be ./gradlew bwcTestSuite -Dtests.security.manager=false -PcustomDistributionDownloadType=bundle
If property customDistributionDownloadType is not set nor set to bundle, the BWC tests would be default to run in plugins level as previously configured.

Issues Resolved

Part of opensearch-project/opensearch-build#2870

CheckList:
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh zelinh requested a review from a team January 5, 2023 22:54
@codecov-commenter
Copy link

Codecov Report

Merging #735 (be6f468) into 2.x (c0f539b) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #735      +/-   ##
============================================
- Coverage     75.31%   75.24%   -0.08%     
  Complexity      116      116              
============================================
  Files           125      125              
  Lines          6819     6819              
  Branches       1020     1020              
============================================
- Hits           5136     5131       -5     
- Misses         1153     1155       +2     
- Partials        530      533       +3     
Impacted Files Coverage Δ
...rg/opensearch/alerting/BucketLevelMonitorRunner.kt 78.26% <0.00%> (-1.31%) ⬇️
...destinationmigration/DestinationConversionUtils.kt 70.00% <0.00%> (-1.12%) ⬇️
...ain/kotlin/org/opensearch/alerting/AlertService.kt 78.60% <0.00%> (-0.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@lezzago
Copy link
Member

lezzago commented Jan 6, 2023

@zelinh Is there a reason this cant be merged to main instead of 2.x?

@zelinh
Copy link
Member Author

zelinh commented Jan 6, 2023

@zelinh Is there a reason this cant be merged to main instead of 2.x?

@lezzago Currently the distribution build for our 3.0.0 are not stable and I haven't validated these tests for major version update. So I'm targeting to 2.5 version for now. I could draft a new PR to backport on main when we getting close to it.

@lezzago
Copy link
Member

lezzago commented Jan 10, 2023

Why do we need the new security credentials files? We already have them here for the security tests: https://github.com/opensearch-project/alerting/tree/2.x/alerting/src/test/resources

@AWSHurneyt AWSHurneyt merged commit 433f4c9 into opensearch-project:2.x Jan 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* Add option to run bwc tests against bundle

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

* Move security certs

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
(cherry picked from commit 433f4c9)
lezzago pushed a commit that referenced this pull request Jan 10, 2023
* Add option to run bwc tests against bundle

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

* Move security certs

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
(cherry picked from commit 433f4c9)

Co-authored-by: Zelin Hao <zelinhao@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants