Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force update snakeyml dependency to 1.32 #566

Closed
wants to merge 1 commit into from

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Sep 26, 2022

Signed-off-by: Ashish Agrawal ashisagr@amazon.com

Issue #, if available:
#539, #540, #541, #542, #543

Description of changes:
Force update SnakeYml dependency

CheckList:
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #566 (ab78397) into main (4ca0fb0) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #566      +/-   ##
============================================
+ Coverage     76.81%   76.90%   +0.09%     
  Complexity      178      178              
============================================
  Files           167      167              
  Lines          8556     8556              
  Branches       1268     1268              
============================================
+ Hits           6572     6580       +8     
+ Misses         1350     1344       -6     
+ Partials        634      632       -2     
Impacted Files Coverage Δ
...ing/model/destination/DestinationContextFactory.kt 75.00% <0.00%> (ø)
.../kotlin/org/opensearch/alerting/core/JobSweeper.kt 74.16% <0.00%> (+0.47%) ⬆️
...nationmigration/DestinationMigrationUtilService.kt 82.25% <0.00%> (+0.80%) ⬆️
...destinationmigration/DestinationConversionUtils.kt 72.22% <0.00%> (+3.33%) ⬆️
...nationmigration/DestinationMigrationCoordinator.kt 68.08% <0.00%> (+6.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lezzago
Copy link
Member Author

lezzago commented Sep 29, 2022

Closing the PR as this issue came from OpenSearch core and they have made the changes with the required backports:
opensearch-project/OpenSearch#4556

@lezzago lezzago closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants