Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Add support for Remote Translog Store upload stats in _nodes/stats/ API #9865

Merged
merged 3 commits into from
Sep 7, 2023
Merged

[Remote Store] Add support for Remote Translog Store upload stats in _nodes/stats/ API #9865

merged 3 commits into from
Sep 7, 2023

Conversation

BhumikaSaini-Amazon
Copy link
Contributor

…_nodes/stats/ API (#8908)

Description

Backport #8908

Related Issues

#8311

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[Remote Store] Add support for Remote Translog Store upload stats in …
3a776d5 
…_nodes/stats/ API (opensearch-project#8908)

---------

Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
@BhumikaSaini-Amazon BhumikaSaini-Amazon changed the title [Remote Store] Add support for Remote Translog Store upload stats in … [Remote Store] Add support for Remote Translog Store upload stats in _nodes/stats/ API Sep 7, 2023
@BhumikaSaini-Amazon BhumikaSaini-Amazon marked this pull request as ready for review September 7, 2023 04:57
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change 3a776d5

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git]

ashking94
ashking94 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ashking94
ashking94 requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found that 2.10 branch has been cut already.

server/src/main/java/org/opensearch/index/translog/TranslogStats.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/index/translog/TranslogStats.java Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #9865 (3a776d5) into 2.x (95025f8) will increase coverage by 0.07%.
Report is 3 commits behind head on 2.x.
The diff coverage is 75.36%.

❗ Current head 3a776d5 differs from pull request most recent head b570e17. Consider uploading reports for the commit b570e17 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #9865      +/-   ##
============================================
+ Coverage     70.82%   70.90%   +0.07%     
- Complexity    58150    58248      +98     
============================================
  Files          4816     4817       +1     
  Lines        274923   275084     +161     
  Branches      40412    40422      +10     
============================================
+ Hits         194727   195038     +311     
+ Misses        63500    63406      -94     
+ Partials      16696    16640      -56
Files Changed Coverage Δ
...in/cluster/remotestore/stats/RemoteStoreStats.java 96.24% <0.00%> (ø)
...rg/opensearch/index/remote/RemoteSegmentStats.java 86.15% <0.00%> (-12.10%) ⬇️
...arch/gateway/remote/RemoteClusterStateService.java 77.93% <78.12%> (-3.11%) ⬇️
...opensearch/index/translog/RemoteTranslogStats.java 82.08% <82.08%> (ø)
...a/org/opensearch/index/translog/TranslogStats.java 90.27% <83.87%> (-0.64%) ⬇️
...epositories/blobstore/ChecksumBlobStoreFormat.java 94.91% <88.23%> (-2.71%) ⬇️
...on/blobstore/transfer/RemoteTransferContainer.java 66.66% <100.00%> (+1.87%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 68.77% <100.00%> (+0.38%) ⬆️
...va/org/opensearch/index/store/RemoteDirectory.java 77.66% <100.00%> (-0.64%) ⬇️

... and 498 files with indirect coverage changes

Change RTS stats version check to V_2_10_0
8faf86b 
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change 8faf86b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

Empty commit to retrigger build
b570e17 
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change b570e17

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Collaborator

gbbafna commented Sep 7, 2023

Looks like we have new flaky test (unrelated to this PR)

org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithRefreshedDataPrimaryReplicaDown

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Collaborator

gbbafna commented Sep 7, 2023 •
edited
Loading

All tests passed . Also this task passed in previous gradle run.

* What went wrong:
Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.
> Process '/var/jenkins/workspace/gradle-check/search/distribution/bwc/bugfix/build/bwc/checkout-2.9/gradlew [-Dbuild.snapshot=true, -Dscan.tag.NESTED, --parallel, distribution:archives:linux-tar:assemble, --build-cache]' finished with non-zero exit value 1

@gbbafna gbbafna merged commit 5796845 into opensearch-project:2.x Sep 7, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashking94 ashking94 ashking94 requested changes

@gbbafna gbbafna gbbafna approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BhumikaSaini-Amazon @gbbafna @ashking94