Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Retry RemoteIndexShardTests flaky tests #9597

Merged

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Aug 29, 2023

Description

Retry RemoteIndexShardTests remote store flaky tests. These tests are failing frequently resulting in check failures, and lot of developer pain. These tests should be retried vs failing the gradle check.
Sample gradle check failrues (there may be more).

  1. https://build.ci.opensearch.org/job/gradle-check/23624
  2. https://build.ci.opensearch.org/job/gradle-check/23669

Related Issues

Resolves None
Related

  1. [BUG] opensearch.index.shard/RemoteIndexShardTests/testNRTReplicaWithRemoteStorePromotedAsPrimaryRefreshCommit flaky test failure #9598
  2. [BUG] org.opensearch.index.shard.RemoteIndexShardTests.testNRTReplicaWithRemoteStorePromotedAsPrimaryCommitRefresh is flaky #9586

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #9597 (60d9548) into main (569d5c2) will decrease coverage by 0.10%.
Report is 5 commits behind head on main.
The diff coverage is 72.22%.

@@             Coverage Diff              @@
##               main    #9597      +/-   ##
============================================
- Coverage     71.15%   71.06%   -0.10%     
+ Complexity    57536    57482      -54     
============================================
  Files          4781     4781              
  Lines        271197   271212      +15     
  Branches      39595    39596       +1     
============================================
- Hits         192975   192736     -239     
- Misses        62011    62261     +250     
- Partials      16211    16215       +4     
Files Changed Coverage Δ
.../opensearch/telemetry/tracing/noop/NoopTracer.java 57.14% <0.00%> (-9.53%) ⬇️
...rg/opensearch/telemetry/tracing/WrappedTracer.java 78.57% <50.00%> (-6.05%) ⬇️
...elemetry/tracing/OTelTracingContextPropagator.java 73.33% <70.00%> (-1.67%) ⬇️
...rg/opensearch/telemetry/tracing/DefaultTracer.java 93.10% <100.00%> (+0.51%) ⬆️
...racing/ThreadContextBasedTracerContextStorage.java 74.19% <100.00%> (+0.86%) ⬆️

... and 503 files with indirect coverage changes

@kotwanikunal kotwanikunal merged commit 8324b88 into opensearch-project:main Aug 30, 2023
14 of 42 checks passed
@dreamer-89 dreamer-89 added the backport 2.x Backport to 2.x branch label Aug 30, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2023
Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit 8324b88)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Aug 30, 2023
(cherry picked from commit 8324b88)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…oject#9597)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…oject#9597)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…oject#9597)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants