Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH runners memory issue by increasing swapfile #9596

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

gaiksaya
Copy link
Member

Description

Compatibility-check workflow runs are frequently failing with shutdown signal sent to GH runners.

The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This change increases the swapfile on the GH ubuntu runner to 10G as suggested here. Tried in my fork and triggered 10 simultaneous runs https://github.com/gaiksaya/OpenSearch/actions/workflows/check-compatibility.yml and all of them passed.

Related Issues

Resolves #9549

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 02573e1

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #9596 (02573e1) into main (012c4fa) will increase coverage by 0.69%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9596      +/-   ##
============================================
+ Coverage     70.40%   71.09%   +0.69%     
- Complexity    56861    57461     +600     
============================================
  Files          4781     4781              
  Lines        271231   271231              
  Branches      39599    39599              
============================================
+ Hits         190947   192843    +1896     
+ Misses        63974    62089    -1885     
+ Partials      16310    16299      -11     

see 589 files with indirect coverage changes

@andrross andrross merged commit 81c7b97 into opensearch-project:main Aug 29, 2023
14 of 39 checks passed
@gaiksaya gaiksaya deleted the fix-memory branch August 30, 2023 00:54
@gaiksaya gaiksaya added the backport 2.x Backport to 2.x branch label Aug 30, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2023
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
(cherry picked from commit 81c7b97)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
tlfeng pushed a commit that referenced this pull request Aug 30, 2023
(cherry picked from commit 81c7b97)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@dblock
Copy link
Member

dblock commented Aug 31, 2023

I found https://github.com/marketplace/actions/set-swap-space that does the same thing and looks a bit neater + displays the results.

@gaiksaya
Copy link
Member Author

I found https://github.com/marketplace/actions/set-swap-space that does the same thing and looks a bit neater + displays the results.

Looks like it is not maintained or actively developed. Last commit and release was in 2021.

kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…t#9596)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…t#9596)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…t#9596)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Compatibility checks keeps failing
3 participants