Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Set replication type to SEGMENT in remote store enabled cluster if nothing specified by user (#9264) #9572

Merged

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented Aug 28, 2023


Signed-off-by: bansvaru bansvaru@amazon.com
Signed-off-by: Varun Bansal bansvaru@amazon.com
(cherry picked from commit a1d8beb)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…thing specified by user (opensearch-project#9264)

---------

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Varun Bansal <bansvaru@amazon.com>
(cherry picked from commit a1d8beb)
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change dc11b31

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      3 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.highlight/20_fvh/Highlight multiple documents}

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #9572 (dc11b31) into 2.x (7a03a66) will decrease coverage by 0.05%.
Report is 3 commits behind head on 2.x.
The diff coverage is 86.40%.

@@             Coverage Diff              @@
##                2.x    #9572      +/-   ##
============================================
- Coverage     70.77%   70.73%   -0.05%     
- Complexity    57617    57624       +7     
============================================
  Files          4768     4769       +1     
  Lines        272372   272493     +121     
  Branches      40117    40123       +6     
============================================
- Hits         192784   192750      -34     
- Misses        63113    63219     +106     
- Partials      16475    16524      +49     
Files Changed Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 93.18% <ø> (ø)
...rc/main/java/org/opensearch/index/IndexModule.java 82.35% <ø> (ø)
...c/main/java/org/opensearch/index/IndexService.java 76.09% <72.22%> (+1.09%) ⬆️
...in/java/org/opensearch/indices/IndicesService.java 71.03% <74.07%> (+2.85%) ⬆️
...g/opensearch/common/util/ReorganizingLongHash.java 93.65% <75.00%> (-1.67%) ⬇️
...rc/main/java/org/opensearch/common/hash/T1ha1.java 89.23% <89.23%> (ø)
.../java/org/opensearch/common/util/BytesRefHash.java 89.18% <89.70%> (+1.31%) ⬆️
...h/cluster/metadata/MetadataCreateIndexService.java 78.98% <94.11%> (-0.13%) ⬇️
...n/src/main/java/org/opensearch/common/Numbers.java 88.65% <100.00%> (-0.93%) ⬇️
...luster/metadata/MetadataUpdateSettingsService.java 70.74% <100.00%> (-0.38%) ⬇️
... and 4 more

... and 468 files with indirect coverage changes

@linuxpi linuxpi marked this pull request as ready for review August 28, 2023 09:42
@linuxpi linuxpi changed the title Set replication type to SEGMENT in remote store enabled cluster if nothing specified by user (#9264) [Backport 2.x] Set replication type to SEGMENT in remote store enabled cluster if nothing specified by user (#9264) Aug 28, 2023
@sachinpkale sachinpkale merged commit 7a0b4c5 into opensearch-project:2.x Aug 28, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants