Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport-2.x] Adding extra fields under RemoteStore stats in NodeStats #9544

Merged
merged 3 commits into from
Aug 25, 2023
Merged

[Backport-2.x] Adding extra fields under RemoteStore stats in NodeStats #9544

merged 3 commits into from
Aug 25, 2023

Conversation

shourya035
Copy link
Member

Description

Backporting #9393 and #9454 to 2.x branch

Removing version checks also in this backport PR. Changes in main to remove the version checks would follow this PR.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shourya035
[Remote Store] Add cumulative bytes lag to NodesStats (opensearch-pro…
0c45fde 
…ject#9393)

---------

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
(cherry picked from commit 784a473)
@shourya035
[Remote Store] Add total upload and download time from remote store t…
cb49110 
…o nodes stats (opensearch-project#9454)

---------

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
(cherry picked from commit c90b6ea)
@shourya035
Removing version checks
9160e5a 
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 9160e5a

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@shourya035 shourya035 marked this pull request as ready for review August 25, 2023 07:52
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #9544 (9160e5a) into 2.x (f147372) will decrease coverage by 0.07%.
The diff coverage is 94.06%.

@@             Coverage Diff              @@
##                2.x    #9544      +/-   ##
============================================
- Coverage     70.83%   70.77%   -0.07%     
+ Complexity    57660    57628      -32     
============================================
  Files          4766     4766              
  Lines        272239   272312      +73     
  Branches      40117    40117              
============================================
- Hits         192842   192726     -116     
- Misses        62893    63058     +165     
- Partials      16504    16528      +24
Files Changed Coverage Δ
...rc/main/java/org/opensearch/index/store/Store.java 81.66% <33.33%> (+0.71%) ⬆️
...search/index/shard/RemoteStoreRefreshListener.java 85.55% <78.57%> (-0.16%) ⬇️
...rch/index/remote/RemoteSegmentTransferTracker.java 81.25% <95.45%> (+0.70%) ⬆️
...arch/index/store/DirectoryFileTransferTracker.java 85.56% <97.67%> (+3.13%) ⬆️
...rg/opensearch/index/remote/RemoteSegmentStats.java 98.24% <100.00%> (+0.62%) ⬆️

... and 468 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 9ae53eb into opensearch-project:2.x Aug 25, 2023
36 checks passed
@shourya035 shourya035 mentioned this pull request Aug 25, 2023
Merged
6 tasks
@shourya035 shourya035 deleted the backport-9454-9393-2.x branch August 25, 2023 09:15
Bukhtawar
Bukhtawar reviewed Aug 25, 2023
View reviewed changes
server/src/main/java/org/opensearch/index/remote/RemoteSegmentStats.java
Comment on lines +89 to +91
totalRefreshBytesLag = in.readLong();
totalUploadTime = in.readLong();
totalDownloadTime = in.readLong();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a version check for 2.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukhtawar Bukhtawar Bukhtawar left review comments

@sachinpkale sachinpkale sachinpkale approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shourya035 @sachinpkale @Bukhtawar