Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] Fix bug where replica shows stale doc count during engine reset. #9495

Merged
merged 4 commits into from
Aug 28, 2023
Merged

[Segment Replication] Fix bug where replica shows stale doc count during engine reset. #9495

merged 4 commits into from
Aug 28, 2023

Commits on Aug 28, 2023

  1. Fix bug where replica shows stale doc count during engine reset. 

    This change fixes an issue where replica shards can temporarily return stale results while converting to a RO engine during an engine reset.  This is possible because NRTReplicationEngine did not previously implement flush and the freshest data is only active on the reader. Fixed by implementing flush and also honoring acquireLatestCommit's flushFirst parameter.

Signed-off-by: Marc Handalian <handalm@amazon.com>
    @mch2
    mch2 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c22befb View commit details
    Browse the repository at this point in the history

  2. Add changelog entry. 

    Signed-off-by: Marc Handalian <handalm@amazon.com>
    @mch2
    mch2 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9e9f6db View commit details
    Browse the repository at this point in the history

  3. Add unit test for search during engine reset. 

    Signed-off-by: Marc Handalian <handalm@amazon.com>
    @mch2
    mch2 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    cadfb63 View commit details
    Browse the repository at this point in the history

  4. Remove useless test. 

    Signed-off-by: Marc Handalian <handalm@amazon.com>
    @mch2
    mch2 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    3606e06 View commit details
    Browse the repository at this point in the history