Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.9] Close Zstd Dictionary after execution to avoid any memory leak. (#9403) #9425

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

andrross
Copy link
Member

Backports 5cc7313 to 2.9

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…search-project#9403)

* Close Dictionary after every execution to avoid any memory leak

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>

* Close Dictionary after every execution to avoid any memory leak

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>

* Add changelog

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>

---------

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
(cherry picked from commit 5cc7313)
Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Aug 17, 2023

@andrross 2.9 needs BWC update for 1.3.x:

* What went wrong:
Execution failed for task ':distribution:bwc:maintenance:buildBwcLinuxTar'.
> Building 1.3.12 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/maintenance/build/bwc/checkout-1.3/distribution/archives/linux-tar/build/distributions/opensearch-min-1.3.12-SNAPSHOT-linux-x64.tar.gz

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.classMethod
      1 org.opensearch.search.ConcurrentSegmentSearchTimeoutIT.testSimpleTimeout
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testScrollWithConcurrentIndexAndSearch

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #9425 (ca084dc) into 2.9 (3309b2e) will increase coverage by 0.14%.
The diff coverage is 72.00%.

@@             Coverage Diff              @@
##                2.9    #9425      +/-   ##
============================================
+ Coverage     70.53%   70.67%   +0.14%     
- Complexity    57076    57126      +50     
============================================
  Files          4746     4746              
  Lines        270723   270726       +3     
  Branches      39952    39952              
============================================
+ Hits         190944   191340     +396     
+ Misses        63344    62967     -377     
+ Partials      16435    16419      -16     
Files Changed Coverage Δ
.../index/codec/customcodecs/ZstdCompressionMode.java 86.66% <70.83%> (+0.30%) ⬆️
...ibs/core/src/main/java/org/opensearch/Version.java 83.25% <100.00%> (-0.82%) ⬇️

... and 476 files with indirect coverage changes

@reta reta merged commit 40fe9d8 into opensearch-project:2.9 Aug 18, 2023
8 checks passed
@andrross andrross deleted the backport/backport-9403-to-2.9 branch August 18, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants