-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remove] Joda from Serialization #9350
[Remove] Joda from Serialization #9350
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:
|
Opened #9355 as a prereq to this PR. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
In Legacy 7.0 joda time was removed in favor of java time to support nanoseconds properly. This commit removes joda from the serialization including ignoring the joda flag sent over the wire for DocValueFormat. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
9a309a8
to
f2887a3
Compare
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
f2887a3
to
25c9a3b
Compare
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 5cc7313 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9350 +/- ##
============================================
- Coverage 71.12% 71.09% -0.03%
+ Complexity 57414 57363 -51
============================================
Files 4776 4776
Lines 270713 270695 -18
Branches 39574 39575 +1
============================================
- Hits 192538 192457 -81
+ Misses 62011 62005 -6
- Partials 16164 16233 +69
|
server/src/main/java/org/opensearch/common/xcontent/XContentOpenSearchExtension.java
Show resolved
Hide resolved
@nknize LGMT but could we now drop |
@reta Not yet. |
In Legacy 7.0 joda time was removed in favor of java time to support nanoseconds properly. This commit removes joda from the serialization including ignoring the joda flag sent over the wire for DocValueFormat. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
In Legacy 7.0 joda time was removed in favor of java time to support nanoseconds properly. This commit removes joda from the serialization including ignoring the joda flag sent over the wire for DocValueFormat. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
In Legacy 7.0 joda time was removed in favor of java time to support nanoseconds properly. This commit removes joda from the serialization including ignoring the joda flag sent over the wire for DocValueFormat. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
In Legacy 7.0 joda time was removed in favor of java time to support nanoseconds properly. This commit removes joda from the serialization including ignoring the joda flag sent over the wire for DocValueFormat. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
In Legacy 7.0 joda time was removed in favor of java time to support nanoseconds properly. This commit removes joda from the serialization including ignoring the joda flag sent over the wire for DocValueFormat. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
In Legacy 7.0 joda time was removed in favor of java time to support nanoseconds properly. This commit removes joda from the serialization including ignoring the joda flag sent over the wire for DocValueFormat. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
In Legacy 7.0 joda time was removed in favor of java time to support nanoseconds properly. This commit removes joda from the serialization including ignoring the joda flag sent over the wire for DocValueFormat. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
In Legacy 7.0 joda time was removed in favor of java time to support nanoseconds properly. This PR removes joda from the serialization including ignoring the joda flag sent over the wire for DocValueFormat.
relates #9349
depends on #9355