Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] Joda from Serialization #9350

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Aug 15, 2023

In Legacy 7.0 joda time was removed in favor of java time to support nanoseconds properly. This PR removes joda from the serialization including ignoring the joda flag sent over the wire for DocValueFormat.

relates #9349
depends on #9355

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 26m 15s

@nknize
Copy link
Collaborator Author

nknize commented Aug 15, 2023

Opened #9355 as a prereq to this PR.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

In Legacy 7.0 joda time was removed in favor of java time to support
nanoseconds properly. This commit removes joda from the serialization
including ignoring the joda flag sent over the wire for DocValueFormat.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the removeJodaFromSerialization branch from 9a309a8 to f2887a3 Compare August 17, 2023 13:15
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the removeJodaFromSerialization branch from f2887a3 to 25c9a3b Compare August 17, 2023 13:16
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 5cc7313

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #9350 (25c9a3b) into main (5cc7313) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 56.25%.

@@             Coverage Diff              @@
##               main    #9350      +/-   ##
============================================
- Coverage     71.12%   71.09%   -0.03%     
+ Complexity    57414    57363      -51     
============================================
  Files          4776     4776              
  Lines        270713   270695      -18     
  Branches      39574    39575       +1     
============================================
- Hits         192538   192457      -81     
+ Misses        62011    62005       -6     
- Partials      16164    16233      +69     
Files Changed Coverage Δ
.../opensearch/core/common/io/stream/StreamInput.java 88.28% <0.00%> (+0.61%) ⬆️
...a/org/opensearch/common/io/stream/Streamables.java 100.00% <ø> (ø)
...st/action/cat/RestCatSegmentReplicationAction.java 45.54% <0.00%> (ø)
...ain/java/org/opensearch/search/DocValueFormat.java 59.50% <33.33%> (-4.08%) ⬇️
...h/common/xcontent/XContentOpenSearchExtension.java 86.53% <100.00%> (-1.99%) ⬇️
...nsearch/rest/action/cat/RestCatRecoveryAction.java 86.17% <100.00%> (ø)

... and 488 files with indirect coverage changes

@nknize nknize requested a review from reta August 18, 2023 14:06
@reta
Copy link
Collaborator

reta commented Aug 18, 2023

@nknize LGMT but could we now drop api "joda-time:joda-time:${versions.joda}" from server deps?

@nknize
Copy link
Collaborator Author

nknize commented Aug 18, 2023

LGMT but could we now drop api "joda-time:joda-time:${versions.joda}" from server deps?

@reta Not yet. DateObjectValuesSource and DateObject still need to be switched to java time internally. I've got a follow up PR to take care of that. I'm just trying to keep these PRs from getting super large unless they have to.

@nknize nknize merged commit bf10ff7 into opensearch-project:main Aug 18, 2023
11 of 12 checks passed
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Aug 25, 2023
In Legacy 7.0 joda time was removed in favor of java time to support
nanoseconds properly. This commit removes joda from the serialization
including ignoring the joda flag sent over the wire for DocValueFormat.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
In Legacy 7.0 joda time was removed in favor of java time to support
nanoseconds properly. This commit removes joda from the serialization
including ignoring the joda flag sent over the wire for DocValueFormat.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
In Legacy 7.0 joda time was removed in favor of java time to support
nanoseconds properly. This commit removes joda from the serialization
including ignoring the joda flag sent over the wire for DocValueFormat.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
In Legacy 7.0 joda time was removed in favor of java time to support
nanoseconds properly. This commit removes joda from the serialization
including ignoring the joda flag sent over the wire for DocValueFormat.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
In Legacy 7.0 joda time was removed in favor of java time to support
nanoseconds properly. This commit removes joda from the serialization
including ignoring the joda flag sent over the wire for DocValueFormat.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
In Legacy 7.0 joda time was removed in favor of java time to support
nanoseconds properly. This commit removes joda from the serialization
including ignoring the joda flag sent over the wire for DocValueFormat.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
In Legacy 7.0 joda time was removed in favor of java time to support
nanoseconds properly. This commit removes joda from the serialization
including ignoring the joda flag sent over the wire for DocValueFormat.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility enhancement Enhancement or improvement to existing feature or request pending backport Identifies an issue or PR that still needs to be backported skip-changelog v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants