Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [2.x] [BWC and API enforcement] Define the initial set of annotations, their meaning and relations between them (#9223) #9296

Merged
merged 2 commits into from
Aug 14, 2023
Merged

[Backport] [2.x] [BWC and API enforcement] Define the initial set of annotations, their meaning and relations between them (#9223) #9296

merged 2 commits into from
Aug 14, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Aug 14, 2023

Backport of #9223 to 2.x

@reta
[BWC and API enforcement] Define the initial set of annotations, thei…
51492f2 
…r meaning and relations between them (opensearch-project#9223)

* [BWC and API enforcement] Define the initial set of annotations, their meaning and relations between them

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Peter Nied <petern@amazon.com>
Co-authored-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 0b2c07a)
@reta reta added the backport PRs or issues specific to backporting features or enhancments label Aug 14, 2023
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 24m 43s

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue

@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #9296 (2eb57ab) into 2.x (d30199f) will increase coverage by 0.08%.
Report is 4 commits behind head on 2.x.
The diff coverage is 82.44%.

@@             Coverage Diff              @@
##                2.x    #9296      +/-   ##
============================================
+ Coverage     70.80%   70.89%   +0.08%     
- Complexity    57491    57543      +52     
============================================
  Files          4759     4761       +2     
  Lines        271848   271906      +58     
  Branches      40093    40094       +1     
============================================
+ Hits         192481   192757     +276     
+ Misses        62846    62626     -220     
- Partials      16521    16523       +2
Files Changed Coverage Δ
.../opensearch/telemetry/tracing/noop/NoopTracer.java 66.66% <0.00%> (-13.34%) ⬇️
...nsearch/script/mustache/SearchTemplateRequest.java 77.27% <0.00%> (-2.17%) ⬇️
...nsearch/index/shard/CheckpointRefreshListener.java 84.61% <ø> (+7.69%) ⬆️
...earch/index/store/RemoteSegmentStoreDirectory.java 87.70% <0.00%> (ø)
...index/shard/CloseableRetryableRefreshListener.java 76.78% <67.64%> (+3.45%) ⬆️
...rch/telemetry/tracing/OTelAttributesConverter.java 85.71% <85.71%> (ø)
...rch/index/remote/RemoteSegmentTransferTracker.java 89.56% <86.36%> (+0.36%) ⬆️
...search/index/shard/RemoteStoreRefreshListener.java 85.71% <95.45%> (+2.56%) ⬆️
...rg/opensearch/telemetry/tracing/DefaultTracer.java 92.59% <100.00%> (+0.28%) ⬆️
...earch/telemetry/tracing/attributes/Attributes.java 100.00% <100.00%> (ø)
... and 3 more

... and 493 files with indirect coverage changes

@reta
[BWC and API enforcement] Extend the element types the initial set of…
2eb57ab 
… annotations could be applied to

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 31m 16s

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta mentioned this pull request Aug 14, 2023
Merged
6 tasks
@reta reta merged commit 55ab42d into opensearch-project:2.x Aug 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reta @nknize