Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add safeguards limits for file cache #8989

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

kotwanikunal
Copy link
Member

Description

Related Issues

Resolves #7713 on 2.x

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…nsearch-project#8208)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 91bfa01)
…pensearch-project#8606)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit a3aab67)
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #8989 (e0c5bf3) into 2.x (d83386c) will decrease coverage by 0.03%.
The diff coverage is 87.65%.

@@             Coverage Diff              @@
##                2.x    #8989      +/-   ##
============================================
- Coverage     70.75%   70.73%   -0.03%     
+ Complexity    57361    57336      -25     
============================================
  Files          4747     4747              
  Lines        271124   271199      +75     
  Branches      39991    40003      +12     
============================================
- Hits         191826   191822       -4     
- Misses        62852    62956     +104     
+ Partials      16446    16421      -25     
Files Changed Coverage Δ
...ster/snapshots/restore/RestoreSnapshotRequest.java 64.20% <ø> (-1.17%) ⬇️
...rg/opensearch/common/settings/ClusterSettings.java 93.18% <ø> (ø)
.../main/java/org/opensearch/cluster/ClusterInfo.java 58.45% <62.50%> (-0.07%) ⬇️
.../java/org/opensearch/snapshots/RestoreService.java 56.80% <82.50%> (+2.47%) ⬆️
...opensearch/cluster/InternalClusterInfoService.java 74.67% <100.00%> (-0.99%) ⬇️
...a/org/opensearch/cluster/routing/RoutingTable.java 94.82% <100.00%> (+0.44%) ⬆️
...uting/allocation/decider/DiskThresholdDecider.java 73.98% <100.00%> (+1.35%) ⬆️
...search/index/store/remote/filecache/FileCache.java 72.46% <100.00%> (+0.40%) ⬆️
server/src/main/java/org/opensearch/node/Node.java 86.06% <100.00%> (ø)

... and 421 files with indirect coverage changes

@kotwanikunal
Copy link
Member Author

@reta Can you please have a look at this backport PR?

@kotwanikunal kotwanikunal merged commit dd5fe57 into opensearch-project:2.x Jul 31, 2023
30 checks passed
@reta
Copy link
Collaborator

reta commented Jul 31, 2023

@reta Can you please have a look at this backport PR?

@kotwanikunal Sorry about it, just saw the comment, thanks @mch2 !

@kotwanikunal kotwanikunal deleted the backport-8606 branch September 21, 2023 18:24
@Dileep-Dora
Copy link

HI @kotwanikunal when is the release planned for this?

@kotwanikunal
Copy link
Member Author

@Dileep-Dora This will be released as a part of v2.10. You can follow the release here: opensearch-project/opensearch-build#3743

@Dileep-Dora
Copy link

@kotwanikunal Thanks for the reply any tentative date on the release?

@kotwanikunal
Copy link
Member Author

@kotwanikunal Thanks for the reply any tentative date on the release?

It is on 9/25 (the upcoming Monday).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants