Adds support for tracing runnable scenarios #8831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gaganjuneja
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8831 +/- ##
============================================
+ Coverage 71.06% 71.15% +0.09%
- Complexity 57314 57359 +45
============================================
Files 4766 4767 +1
Lines 270453 270503 +50
Branches 39555 39555
============================================
+ Hits 192197 192480 +283
+ Misses 62045 61844 -201
+ Partials 16211 16179 -32
|
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
reviewed
Jul 24, 2023
libs/telemetry/src/main/java/org/opensearch/telemetry/tracing/DefaultTracer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
Compatibility status: |
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
Aug 8, 2023
libs/telemetry/src/main/java/org/opensearch/telemetry/tracing/TracerContextStorage.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
Aug 8, 2023
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
|
Flakey shard allocation failure tests. |
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
|
Compatibility status: |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8831-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7655c32a441facaf627c2d703f6b39489987e542
# Push it to GitHub
git push --set-upstream origin backport/backport-8831-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
|
@Gaganjuneja please send a manual backport to |
6 tasks
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
* Add support for tracer to create new TracerContextStorage Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updated CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Refactoring Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds feature to expose current span and start span with parent Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updating the CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds feature to expose current span and start span with parent Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds feature to expose current span and start span with parent Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Update Changelog Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Remove empty lines Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
* Add support for tracer to create new TracerContextStorage Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updated CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Refactoring Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds feature to expose current span and start span with parent Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updating the CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds feature to expose current span and start span with parent Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds feature to expose current span and start span with parent Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Update Changelog Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Remove empty lines Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
* Add support for tracer to create new TracerContextStorage Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updated CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Refactoring Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds feature to expose current span and start span with parent Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Updating the CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds feature to expose current span and start span with parent Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds feature to expose current span and start span with parent Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Update Changelog Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Remove empty lines Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue -
Addresses the issue with code change #7543
For an instance where multiple tasks are being submitted from a loop the parent span is getting wrongly set.
Example :-
Parent - AperformPhaseOnShard executes the phase on the node where the shard is located, it could be locally or external data node. If we start a span from inside the performPhaseOnShard method, it creates the shard and sets this newly created span as a parent for the future spans. E.x here
performPhaseOnShard for shard
Bwill have parent span asA.performPhaseOnShard for shard
Cwill have parent span asB. Which is wrong and should ideally beASimilarly, performPhaseOnShard for shard
Cwill have a parent span asC.Ideally we need to reset the context in this scenario, so Tracer should provide a new Releasable TracerContext which can be reset to the original one of releasing the current context.
Related Issues
Resolves #8428
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.