Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Change InternalSignificantTerms to only sum shard level counts in final reduce (#8735) #8806

Merged

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Jul 20, 2023

Backport PR for #8735

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@jed326
Copy link
Collaborator Author

jed326 commented Jul 20, 2023

@andrross here is the backport PR for #8735. Thanks!

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #8806 (86d577e) into 2.x (d83147f) will decrease coverage by 0.19%.
The diff coverage is 64.04%.

@@             Coverage Diff              @@
##                2.x    #8806      +/-   ##
============================================
- Coverage     70.80%   70.61%   -0.19%     
+ Complexity    57405    57309      -96     
============================================
  Files          4759     4758       -1     
  Lines        271578   271488      -90     
  Branches      40034    40020      -14     
============================================
- Hits         192283   191716     -567     
- Misses        62795    63307     +512     
+ Partials      16500    16465      -35     
Impacted Files Coverage Δ
...cluster/reroute/TransportClusterRerouteAction.java 46.05% <0.00%> (+1.31%) ⬆️
...ices/shards/TransportIndicesShardStoresAction.java 4.90% <0.00%> (ø)
...a/org/opensearch/cluster/routing/RoutingTable.java 94.37% <ø> (ø)
...on/lucene/search/function/RandomScoreFunction.java 68.96% <ø> (ø)
...java/org/opensearch/common/recycler/Recyclers.java 91.42% <ø> (ø)
...g/opensearch/common/util/AbstractPagedHashMap.java 71.05% <ø> (ø)
.../java/org/opensearch/common/util/BytesRefHash.java 87.87% <ø> (ø)
.../java/org/opensearch/common/util/LongLongHash.java 92.59% <ø> (ø)
...g/opensearch/common/util/ReorganizingLongHash.java 95.31% <ø> (ø)
.../src/main/java/org/opensearch/gateway/Gateway.java 8.33% <0.00%> (ø)
... and 52 more

... and 468 files with indirect coverage changes

@andrross andrross merged commit 9524683 into opensearch-project:2.x Jul 21, 2023
30 of 31 checks passed
@andrross andrross changed the title Change InternalSignificantTerms to only sum shard level counts in final reduce (#8735) [Backport 2.x] Change InternalSignificantTerms to only sum shard level counts in final reduce (#8735) Jul 21, 2023
@andrross andrross added the backport PRs or issues specific to backporting features or enhancments label Jul 21, 2023
@jed326 jed326 deleted the backport/backport-8735-to-2.x branch September 13, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants