Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Pipeline] Flip SEARCH_PIPELINE feature flag for Search Pipeline GA #8613

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

noCharger
Copy link
Contributor

@noCharger noCharger commented Jul 11, 2023

Description

Flip the feature flag as described in #8513 (comment)

Related Issues

#8489

Check List

  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@noCharger noCharger changed the title Flip SEARCH_PIPELINE feature flag for GA [Search Pipeline] Flip SEARCH_PIPELINE feature flag for Search Pipeline GA Jul 11, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Louis Chu <clingzhi@amazon.com>
Signed-off-by: Louis Chu <clingzhi@amazon.com>
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #8613 (5c1974c) into main (a430e18) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 5c1974c differs from pull request most recent head 20314ad. Consider uploading reports for the commit 20314ad to get more accurate results

@@             Coverage Diff              @@
##               main    #8613      +/-   ##
============================================
+ Coverage     70.87%   70.91%   +0.04%     
+ Complexity    56962    56956       -6     
============================================
  Files          4758     4758              
  Lines        269510   269417      -93     
  Branches      39446    39420      -26     
============================================
+ Hits         191005   191053      +48     
+ Misses        62440    62318     -122     
+ Partials      16065    16046      -19     
Impacted Files Coverage Δ
.../java/org/opensearch/common/util/FeatureFlags.java 92.30% <100.00%> (ø)

... and 448 files with indirect coverage changes

@noCharger noCharger requested a review from msfroh July 11, 2023 08:47
@noCharger noCharger self-assigned this Jul 11, 2023
@noCharger noCharger added the v2.9.0 'Issues and PRs related to version v2.9.0' label Jul 11, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessAfterFailureInFirstAttemptAfterSnapshotAndMetadataUpload
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Jul 11, 2023

@noCharger we need to update the documentation for this feature [1], could you please create an issue there? thank you

[1] https://github.com/opensearch-project/documentation-website/tree/main/_search-plugins/search-pipelines

@reta
Copy link
Collaborator

reta commented Jul 11, 2023

Flaky tests failures from #8131

@reta
Copy link
Collaborator

reta commented Jul 11, 2023

Precommit crashes JVM on Windows (twice):

Exec output and error:
> Task :modules:reindex:jarHell FAILED
| Output for C:\hostedtoolcache\windows\Java_Adopt_jdk\11.0.19-7\x64\bin\java.exe:OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x0000000090000000, 117440512, 0) failed; error='The paging file is too small for this operation to complete' (DOS error/errno=1455)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 117440512 bytes for Failed to commit area from 0x0000000090000000 to 0x0000000097000000 of length 117440512.
# An error report file with more information is saved as:
# D:\a\OpenSearch\OpenSearch\modules\reindex\hs_err_pid7140.log

 JVM crash log found: file:///D:/a/OpenSearch/OpenSearch/hs_err_pid5260.log

@noCharger
Copy link
Contributor Author

noCharger commented Jul 11, 2023

@noCharger we need to update the documentation for this feature [1], could you please create an issue there? thank you

[1] https://github.com/opensearch-project/documentation-website/tree/main/_search-plugins/search-pipelines

@reta Issue created, thanks!

Existing one opensearch-project/documentation-website#4502

@reta
Copy link
Collaborator

reta commented Jul 11, 2023

@msfroh looks good to you?

@noCharger
Copy link
Contributor Author

@msfroh @andrross need more eyes on this PR. Thanks!

Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This can be merged.

@macohen
Copy link
Contributor

macohen commented Jul 11, 2023

@reta are you able to merge, please? any other concerns or need for @andrross to take a look?

@reta reta merged commit 0515501 into opensearch-project:main Jul 11, 2023
14 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Jul 11, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8613-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 051550112c7ae7ae1e81f9da3eff10c73407cf38
# Push it to GitHub
git push --set-upstream origin backport/backport-8613-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8613-to-2.x.

noCharger added a commit to noCharger/OpenSearch that referenced this pull request Jul 11, 2023
…project#8613)

Signed-off-by: Louis Chu <clingzhi@amazon.com>
(cherry picked from commit 0515501)
nknize pushed a commit that referenced this pull request Jul 11, 2023
Signed-off-by: Louis Chu <clingzhi@amazon.com>
(cherry picked from commit 0515501)
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…project#8613)

Signed-off-by: Louis Chu <clingzhi@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…project#8613)

Signed-off-by: Louis Chu <clingzhi@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants