[Snapshot Interop] Add Logic in Lock Manager to cleanup stale data po… #8472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishbhakuni
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
|
tagging @gbbafna @sachinpkale to look into the PR. |
Gradle Check (Jenkins) Run Completed with:
|
harishbhakuni
force-pushed
the
lockManagerChanges
branch
2 times, most recently
from
aea333d
to
3798261
Compare
|
tagging @sohami as well to take a look into the changes. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
harishbhakuni
force-pushed
the
lockManagerChanges
branch
from
f5f03f5
to
2c7b50b
Compare
Gradle Check (Jenkins) Run Completed with:
|
harishbhakuni
force-pushed
the
lockManagerChanges
branch
2 times, most recently
from
20296d3
to
cf89b2b
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Compatibility status: |
|
Compatibility status: |
…st index deletion. Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
harishbhakuni
force-pushed
the
lockManagerChanges
branch
from
cf89b2b
to
87a4658
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8472 +/- ##
============================================
- Coverage 71.01% 71.00% -0.02%
+ Complexity 57248 57238 -10
============================================
Files 4765 4765
Lines 270315 270332 +17
Branches 39534 39537 +3
============================================
- Hits 191972 191946 -26
- Misses 62170 62210 +40
- Partials 16173 16176 +3
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8472-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5670d2a2be92602c8e8e38cc8fec7ddf5737ed52
# Push it to GitHub
git push --set-upstream origin backport/backport-8472-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
VachaShah
pushed a commit
to VachaShah/OpenSearch
that referenced
this pull request
Aug 3, 2023
…st index deletion. (opensearch-project#8472) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
harishbhakuni
added a commit
to harishbhakuni/OpenSearch
that referenced
this pull request
Sep 5, 2023
…st index deletion. (opensearch-project#8472) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> (cherry picked from commit 5670d2a)
harishbhakuni
pushed a commit
to harishbhakuni/OpenSearch
that referenced
this pull request
Sep 5, 2023
…st index deletion. (opensearch-project#8472) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> (cherry picked from commit 5670d2a)
harishbhakuni
pushed a commit
to harishbhakuni/OpenSearch
that referenced
this pull request
Sep 5, 2023
…st index deletion. (opensearch-project#8472) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> (cherry picked from commit 5670d2a)
6 tasks
harishbhakuni
pushed a commit
to harishbhakuni/OpenSearch
that referenced
this pull request
Sep 5, 2023
…st index deletion. (opensearch-project#8472) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> (cherry picked from commit 5670d2a)
harishbhakuni
pushed a commit
to harishbhakuni/OpenSearch
that referenced
this pull request
Sep 5, 2023
…st index deletion. (opensearch-project#8472) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> (cherry picked from commit 5670d2a)
harishbhakuni
pushed a commit
to harishbhakuni/OpenSearch
that referenced
this pull request
Sep 5, 2023
…st index deletion. (opensearch-project#8472) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> (cherry picked from commit 5670d2a)
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
…st index deletion. (opensearch-project#8472) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
…st index deletion. (opensearch-project#8472) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…st index deletion. (opensearch-project#8472) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st index deletion.
Description
Changes to Cleanup Stale Remote Store Data Post Index Deletion if there are no more locks on metadata files.
Here, we are extending LockManager implementation and adding a new method which will along with releasing lock would also attempt cleanup of remote store stale files.
As BlobStoreRepository implementation already have cluster state, we will use that to determine if index is deleted or not, if index is deleted we will call the new method
releaseAndCleanupwhich will release lock and then if there are no more locks in the directory, it will try to cleanup the directory.Related Issues
Resolves #8469
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.