Start replication checkpointTimers on primary before segments upload to remote store.

[ankitkala]

Description

Start replication checkpointTimers on primary before segments upload to remote store.

Related Issues

Resolves #8196

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18181/
• CommitID: 6fdf3cd
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

• URL: https://build.ci.opensearch.org/job/gradle-check/18182/
• CommitID: f5ce3cd
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #8221 (8db8d86) into main (2f9728e) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head 8db8d86 differs from pull request most recent head bf60b34. Consider uploading reports for the commit bf60b34 to get more accurate results

@@             Coverage Diff              @@
##               main    #8221      +/-   ##
============================================
- Coverage     71.01%   70.81%   -0.21%     
+ Complexity    57029    56870     -159     
============================================
  Files          4758     4757       -1     
  Lines        269251   269126     -125     
  Branches      39401    39403       +2     
============================================
- Hits         191214   190581     -633     
- Misses        61958    62431     +473     
- Partials      16079    16114      +35     

Impacted Files	Coverage Δ
...in/java/org/opensearch/index/shard/IndexShard.java	69.42% <100.00%> (-0.17%)	⬇️
...search/index/shard/RemoteStoreRefreshListener.java	89.00% <100.00%> (+5.66%)	⬆️

... and 513 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

• URL: https://build.ci.opensearch.org/job/gradle-check/18335/
• CommitID: 8931b93
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[mch2]

@ankitkala I think we need to open a docs issue with this change so users are aware. We also need to consider backpressure here as this will now further increase "replication lag" between primary & replicas and potentially fail replicas at no fault to them as copy has not even started.

[ankitkala]

@ankitkala I think we need to open a docs issue with this change so users are aware. We also need to consider backpressure here as this will now further increase "replication lag" between primary & replicas and potentially fail replicas at no fault to them as copy has not even started.

Yep. Moreover, I think we need to tune the lag threshold for marking replicas as stale. With remote store upload and download accounting to the lag, the current threshold might not suffice.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationDuringFetchPhase

• URL: https://build.ci.opensearch.org/job/gradle-check/18821/
• CommitID: 8db8d86
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/19274/
• CommitID: 3cf2909
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      2 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testCancellation
      2 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit

• URL: https://build.ci.opensearch.org/job/gradle-check/19395/
• CommitID: bf60b34
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[kotwanikunal]

@mch2 Mind resolving all conversations? Pre-req to merging this in :)

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8221-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32e72619251957cc3e045b29d13f4e3c190a5008
# Push it to GitHub
git push --set-upstream origin backport/backport-8221-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8221-to-2.x.