[Remote Store] Moving stale commit deletion to async flow

[psychbot]

Description

Changes to move the stale commit deletion logic to async flow.

Related Issues

Resolves #4315

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/18116/
• CommitID: aa3c392

[codecov]

Codecov Report

Merging #8201 (5c446f3) into main (b594f52) will decrease coverage by 0.02%.
The diff coverage is 86.95%.

@@             Coverage Diff              @@
##               main    #8201      +/-   ##
============================================
- Coverage     70.86%   70.84%   -0.02%     
+ Complexity    56825    56768      -57     
============================================
  Files          4752     4752              
  Lines        268599   268610      +11     
  Branches      39336    39336              
============================================
- Hits         190335   190292      -43     
- Misses        62235    62243       +8     
- Partials      16029    16075      +46     

Impacted Files	Coverage Δ
...in/java/org/opensearch/index/shard/IndexShard.java	69.21% <0.00%> (-0.33%)	⬇️
...java/org/opensearch/index/shard/StoreRecovery.java	57.25% <0.00%> (-0.42%)	⬇️
...search/index/shard/RemoteStoreRefreshListener.java	85.56% <100.00%> (-4.39%)	⬇️
...earch/index/store/RemoteSegmentStoreDirectory.java	91.91% <100.00%> (+1.86%)	⬆️
...ndex/store/RemoteSegmentStoreDirectoryFactory.java	95.65% <100.00%> (+0.19%)	⬆️
server/src/main/java/org/opensearch/node/Node.java	84.95% <100.00%> (ø)

... and 435 files with indirect coverage changes

[ashking94]

have left couple of comments, do take a look

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/18158/
• CommitID: 6b94980

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

• URL: https://build.ci.opensearch.org/job/gradle-check/18160/
• CommitID: 560c17b
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

• URL: https://build.ci.opensearch.org/job/gradle-check/18600/
• CommitID: 051a512
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18734/
• CommitID: 63e08cf
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18735/
• CommitID: 45b8233
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[ashking94]

Left some minor comments, please take a look.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.remotestore.RemoteStoreIT.testRemoteTranslogCleanup
      1 org.opensearch.remotestore.RemoteStoreIT.testRemoteTranslogCleanup
      1 org.opensearch.remotestore.RemoteStoreIT.testRemoteSegmentCleanup

• URL: https://build.ci.opensearch.org/job/gradle-check/18800/
• CommitID: d541935
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18803/
• CommitID: 5c446f3
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[ashking94]

LGTM

[sachinpkale]

Build failure due to flaky tests.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

• URL: https://build.ci.opensearch.org/job/gradle-check/18919/
• CommitID: 5c446f3
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8201-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1d2274045b42e129b8c06748f8185d2431aa5336
# Push it to GitHub
git push --set-upstream origin backport/backport-8201-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8201-to-2.x.