Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove COMPRESSOR variable from CompressorFactory #7907

Merged

Conversation

willyborankin
Copy link
Contributor

@willyborankin willyborankin commented Jun 4, 2023

Description

The aim of this PR is to remove a deprecated COMPRESSOR variable from
CompressorFactory and use DEFLATE_COMPRESSOR instead.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #7907 (1b833b1) into main (584617e) will increase coverage by 0.12%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##               main    #7907      +/-   ##
============================================
+ Coverage     70.87%   70.99%   +0.12%     
- Complexity    56504    56631     +127     
============================================
  Files          4719     4719              
  Lines        267408   267409       +1     
  Branches      39196    39196              
============================================
+ Hits         189521   189847     +326     
+ Misses        61861    61551     -310     
+ Partials      16026    16011      -15     
Impacted Files Coverage Δ
...java/org/opensearch/transport/TransportLogger.java 40.69% <0.00%> (ø)
...rg/opensearch/transport/TransportDecompressor.java 75.32% <75.00%> (+0.32%) ⬆️
...ch/cluster/coordination/CompressedStreamUtils.java 80.00% <100.00%> (ø)
...opensearch/common/compress/CompressedXContent.java 85.93% <100.00%> (ø)
.../opensearch/common/compress/CompressorFactory.java 57.14% <100.00%> (ø)
...ch/repositories/blobstore/BlobStoreRepository.java 65.01% <100.00%> (+0.23%) ⬆️
...earch/transport/CompressibleBytesOutputStream.java 81.81% <100.00%> (ø)

... and 469 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good at first glance, but I'm missing the context on why we are doing this. Is there an issue discussing the benefit of this change?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Gradle Check (Jenkins) Run Completed with:

@willyborankin willyborankin force-pushed the compression-refactoring branch 2 times, most recently from 1b8d6f5 to ba3ceae Compare June 11, 2023 15:31
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu

Removed a deprecated COMPRESSOR variable from
CompressorFactory and use DEFLATE_COMPRESSOR instea

Signed-off-by: Andrey Pleskach <ples@aiven.io>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Jun 13, 2023

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock dblock merged commit 8c74932 into opensearch-project:main Jun 13, 2023
@dblock dblock added the backport 2.x Backport to 2.x branch label Jun 13, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7907-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c7493203bbedc96efb88581a80198d8d26771db
# Push it to GitHub
git push --set-upstream origin backport/backport-7907-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7907-to-2.x.

@dblock
Copy link
Member

dblock commented Jun 13, 2023

Will need a manual backport @willyborankin if you want it in 2.x.

willyborankin added a commit to willyborankin/OpenSearch that referenced this pull request Jun 14, 2023
…#7907)

Removed a deprecated COMPRESSOR variable from
CompressorFactory and use DEFLATE_COMPRESSOR instea

Signed-off-by: Andrey Pleskach <ples@aiven.io>
willyborankin added a commit to willyborankin/OpenSearch that referenced this pull request Jun 14, 2023
…#7907)

Removed a deprecated COMPRESSOR variable from
CompressorFactory and use DEFLATE_COMPRESSOR instea

Signed-off-by: Andrey Pleskach <ples@aiven.io>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 15, 2023
…#7907)

Removed a deprecated COMPRESSOR variable from
CompressorFactory and use DEFLATE_COMPRESSOR instea

Signed-off-by: Andrey Pleskach <ples@aiven.io>
willyborankin added a commit to willyborankin/OpenSearch that referenced this pull request Jun 15, 2023
…#7907)

Removed a deprecated COMPRESSOR variable from
CompressorFactory and use DEFLATE_COMPRESSOR instea

Signed-off-by: Andrey Pleskach <ples@aiven.io>
reta pushed a commit that referenced this pull request Jun 15, 2023
Removed a deprecated COMPRESSOR variable from
CompressorFactory and use DEFLATE_COMPRESSOR instea

Signed-off-by: Andrey Pleskach <ples@aiven.io>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…#7907) (opensearch-project#8055)

Removed a deprecated COMPRESSOR variable from
CompressorFactory and use DEFLATE_COMPRESSOR instea

Signed-off-by: Andrey Pleskach <ples@aiven.io>
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
…#7907)

Removed a deprecated COMPRESSOR variable from
CompressorFactory and use DEFLATE_COMPRESSOR instea

Signed-off-by: Andrey Pleskach <ples@aiven.io>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…#7907)

Removed a deprecated COMPRESSOR variable from
CompressorFactory and use DEFLATE_COMPRESSOR instea

Signed-off-by: Andrey Pleskach <ples@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants