Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align range and default value for deletes_pct_allowed in merge policy #7730

Conversation

nkumar04
Copy link
Contributor

Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (#7360)

Description

This change is to align the default value of deletesPctAllowed in merge policy with Lucene. This change will help in optimal usage of disk and reduce the deleted docs in an index. Search performance would also be better if there are less deleted docs in an index.

Related Issues

Resolves #7360

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #7730 (29c018e) into main (8773509) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7730      +/-   ##
============================================
- Coverage     70.88%   70.85%   -0.04%     
+ Complexity    56352    56339      -13     
============================================
  Files          4700     4700              
  Lines        266549   266549              
  Branches      39099    39099              
============================================
- Hits         188937   188856      -81     
- Misses        61632    61723      +91     
+ Partials      15980    15970      -10     
Impacted Files Coverage Δ
...n/java/org/opensearch/index/MergePolicyConfig.java 74.66% <ø> (ø)

... and 461 files with indirect coverage changes

Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360)

Signed-off-by: Nikhil Kumar <nikhkumn@amazon.com>
@nkumar04 nkumar04 force-pushed the 7360_merge_policy_tuning_for_del_pct branch from ecb5d6c to 29c018e Compare June 7, 2023 04:44
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@shwetathareja shwetathareja merged commit 9b2b3c9 into opensearch-project:main Jun 12, 2023
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Jun 12, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7730-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9b2b3c94728bc7f5f3771b440245a55341940a38
# Push it to GitHub
git push --set-upstream origin backport/backport-7730-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7730-to-2.x.

nkumar04 added a commit to nkumar04/OpenSearch that referenced this pull request Jun 12, 2023
…opensearch-project#7730)

Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360)

Signed-off-by: Nikhil Kumar <nikhkumn@amazon.com>
Co-authored-by: Nikhil Kumar <nikhkumn@amazon.com>
(cherry picked from commit 9b2b3c9)
shwetathareja pushed a commit that referenced this pull request Jun 12, 2023
…#7730) (#8002)

Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (#7360)

Signed-off-by: Nikhil Kumar <nikhkumn@amazon.com>
Co-authored-by: Nikhil Kumar <nikhkumn@amazon.com>
(cherry picked from commit 9b2b3c9)
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…opensearch-project#7730) (opensearch-project#8002)

Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360)

Signed-off-by: Nikhil Kumar <nikhkumn@amazon.com>
Co-authored-by: Nikhil Kumar <nikhkumn@amazon.com>
(cherry picked from commit 9b2b3c9)
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
…opensearch-project#7730)

Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360)

Signed-off-by: Nikhil Kumar <nikhkumn@amazon.com>
Co-authored-by: Nikhil Kumar <nikhkumn@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…opensearch-project#7730)

Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360)

Signed-off-by: Nikhil Kumar <nikhkumn@amazon.com>
Co-authored-by: Nikhil Kumar <nikhkumn@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
4 participants