Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Moving ExtensionsRequest to use Protobuf #7265

Merged

Conversation

saratvemulapalli
Copy link
Member

Description

Manual backport of #6960 to 2.x

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ject#6960)

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@saratvemulapalli saratvemulapalli added backport PRs or issues specific to backporting features or enhancments extensions v2.8.0 'Issues and PRs related to version v2.8.0' labels Apr 21, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@@ -21,6 +21,7 @@ woodstox = 6.4.0
kotlin = 1.7.10
antlr4 = 4.11.1
guava = 31.1-jre
protobuf = 3.22.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @saratvemulapalli , non-issue but I've just realized a minor update for protobuf is ongoing (https://github.com/opensearch-project/OpenSearch/pull/7261/files), not a big deal, I could rebase it after

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #7265 (b414608) into 2.x (3f9845b) will decrease coverage by 0.04%.
The diff coverage is 64.28%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #7265      +/-   ##
============================================
- Coverage     70.46%   70.42%   -0.04%     
- Complexity    59796    59808      +12     
============================================
  Files          4847     4847              
  Lines        287150   287139      -11     
  Branches      41723    41723              
============================================
- Hits         202336   202219     -117     
- Misses        67891    68023     +132     
+ Partials      16923    16897      -26     
Impacted Files Coverage Δ
...a/org/opensearch/extensions/ExtensionsManager.java 43.39% <0.00%> (-1.90%) ⬇️
...va/org/opensearch/extensions/ExtensionRequest.java 70.83% <69.23%> (-4.17%) ⬇️

... and 485 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saratvemulapalli saratvemulapalli merged commit df8dca7 into opensearch-project:2.x Apr 21, 2023
@saratvemulapalli saratvemulapalli deleted the backport-6960-2.x branch April 21, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments extensions v2.8.0 'Issues and PRs related to version v2.8.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants