Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document creation process for testCacheFilesAreClosedAfterUse IT #6797

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

kotwanikunal
Copy link
Member

Description

  • Uses the standard methods defined within SearchableSnapshotIT to perform index creation, doc creation and green checks for testCacheFilesAreClosedAfterUse
  • Current implementation led to incorrect green checks because of missing shard and replica configs

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #6797 (15bf4f4) into main (f40fa82) will decrease coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #6797      +/-   ##
============================================
- Coverage     70.75%   70.72%   -0.04%     
+ Complexity    59230    59164      -66     
============================================
  Files          4810     4810              
  Lines        283487   283487              
  Branches      40877    40877              
============================================
- Hits         200577   200485      -92     
- Misses        66408    66519     +111     
+ Partials      16502    16483      -19     

see 502 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the flaky test!

@kotwanikunal kotwanikunal merged commit 4d78bbf into opensearch-project:main Mar 23, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2023
…6797)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 4d78bbf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mitrofmep pushed a commit to mitrofmep/OpenSearch that referenced this pull request Apr 5, 2023
…pensearch-project#6797)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Valentin Mitrofanov <mitrofmep@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.snapshots.SearchableSnapshotIT.testCacheFilesAreClosedAfterUse is flaky
3 participants