Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding @gbbafna to OpenSearch maintainers #5668

Merged
merged 3 commits into from
Dec 31, 2022

Conversation

Bukhtawar
Copy link
Collaborator

@Bukhtawar Bukhtawar commented Dec 31, 2022

Signed-off-by: Bukhtawar Khan bukhtawa@amazon.com

Description

I nominated Gaurav Bafna (@gbbafna) to be a co-maintainer for Opensearch through our nomination process. The maintainers have agreed, and Gaurav has kindly accepted.

Gaurav is the lead author and maintainer of Cross Cluster Replication Feature and reviewed/approved significant core contributions like Zonal decommissioning, Weighted shard routing, Master Task Throttling and Remote Store. He personally has also contributed 5 PRs into OpenSearch and 49 PRs for cross cluster replication. He is actively filing key bugs and issues . Gaurav has reviewed 128 PRs and opened 48 issues till now across Cross Cluster Replication and OpenSearch.

Some of Gaurav’s notable code contributions and reviews were:

Gaurav is active in the project, thoughtfully reviewing and commenting on pull requests examples Refresh level durability, Primary term validation for no-op Replication, Zonal decommissioning , Weighted shard routing , Awareness Health API .

Check List

  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2022

Codecov Report

Merging #5668 (8bfd586) into main (51b25a5) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5668      +/-   ##
============================================
+ Coverage     70.98%   71.00%   +0.02%     
- Complexity    58561    58594      +33     
============================================
  Files          4760     4760              
  Lines        279515   279515              
  Branches      40348    40348              
============================================
+ Hits         198400   198457      +57     
+ Misses        64922    64877      -45     
+ Partials      16193    16181      -12     
Impacted Files Coverage Δ
...a/org/opensearch/tasks/TaskCancelledException.java 50.00% <0.00%> (-50.00%) ⬇️
...regations/metrics/AbstractHyperLogLogPlusPlus.java 51.72% <0.00%> (-44.83%) ⬇️
...adcast/BroadcastShardOperationFailedException.java 33.33% <0.00%> (-44.45%) ⬇️
...pensearch/indices/breaker/CircuitBreakerStats.java 27.77% <0.00%> (-41.67%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 42.50% <0.00%> (-35.00%) ⬇️
...ations/bucket/terms/heuristic/PercentageScore.java 17.39% <0.00%> (-34.79%) ⬇️
...r/src/main/java/org/opensearch/http/HttpUtils.java 33.33% <0.00%> (-33.34%) ⬇️
...search/indices/breaker/AllCircuitBreakerStats.java 25.00% <0.00%> (-30.00%) ⬇️
...a/org/opensearch/index/mapper/MapperException.java 75.00% <0.00%> (-25.00%) ⬇️
... and 477 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Bukhtawar Bukhtawar merged commit 361133c into opensearch-project:main Dec 31, 2022
@Bukhtawar Bukhtawar added the backport 2.x Backport to 2.x branch label Dec 31, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5668-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 361133cdfc88632ff72d030ef0ddc0281a6aac77
# Push it to GitHub
git push --set-upstream origin backport/backport-5668-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5668-to-2.x.

@Bukhtawar
Copy link
Collaborator Author

Thanks @reta for the approval, will backport to older branches. Congrats @gbbafna on being a maintainer!!

@Bukhtawar Bukhtawar deleted the gbbafna-maintainer branch December 31, 2022 19:21
gbbafna pushed a commit to gbbafna/OpenSearch that referenced this pull request Jan 4, 2023
…project#5668)

* Adding @gbbafna to Opensearch maintainers

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Bukhtawar pushed a commit that referenced this pull request Jan 4, 2023
* Adding @gbbafna to Opensearch maintainers

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
* Adding @gbbafna to Opensearch maintainers

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants