[Backport 2.x] [Point in time] Backport point in time changes #4616
Conversation
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
…vel client Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
| /** | ||
| * Create point in time for one or more indices | ||
| */ | ||
| void createPit(CreatePitRequest createPITRequest, ActionListener<CreatePitResponse> listener); |
There was a problem hiding this comment.
Posting @reta's comment here - #4406 (comment)
@bharath-techie from the API perspective, this is beaking change. Since we backport to 2.x (no breaking changes), we probably should mark this methods as default.
There was a problem hiding this comment.
@reta by marking default we can remove implementations in case of roll back ? is that the idea ?
|
@reta @Bukhtawar please review. Closed the old backport PR because it had issues like DCO. So made this fresh PR. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
| if (in.getVersion().onOrAfter(Version.V_3_0_0)) { | ||
| if (in.getVersion().onOrAfter(Version.V_2_3_0)) { |
There was a problem hiding this comment.
Is this the only place we are doing serde and relying on versioning?
There was a problem hiding this comment.
And in rest high level tests
There was a problem hiding this comment.
These two test files ^
and searchStats file.
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
There was a problem hiding this comment.
Documenting for posterity: this change caused bwc failures because the version check wasn't set correctly in the original PR.
For future reference (and maybe we need to make sure this is documented in CONRTIBUTING.md) make sure the version checks are set to the intended target version in the initial PR. BWC tests will temporarily fail after the initial merge to main but only until the backport PRs are merged. If you wait, an additional follow up PR will be needed (which could be forgotten as it was here) whereas if you target the correct version in the original PR it will rectify itself on backport.
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Description
Backport point in time changes
Issues Resolved
#1147
Original PRs
Adding create pit service layer changes #3921
Adding delete pit service layer changes #3949
Add service layer changes for list all PITs #4016
Add Point In Time Node Stats API ServiceLayer Changes #4030
Add changes to Point in time segments API service layer #4105
Add changes for Create PIT and Delete PIT rest layer and rest high level client #4064
Added RestLayer Changes for PIT stats #4217
Added rest layer changes for List all PITs and PIT segments #4388
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.