Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Introduce TranslogManager implementations decoupled from the Engine #3771

Closed
wants to merge 1 commit into from
Closed

[Backport 2.x] Introduce TranslogManager implementations decoupled from the Engine #3771

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 078f90c from #3638

@Bukhtawar @github-actions
Introduce TranslogManager implementations decoupled from the Engine (#…
cbba48e 
…3638)

* Introduce decoupled translog manager interfaces

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
(cherry picked from commit 078f90c)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners July 5, 2022 14:10
reta
reta requested changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bukhtawar this change is breaking for Engine implementors, AFAIK we restrain from introducing breaking changes in non-major releases

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Gradle Check (Jenkins) Run Completed with:

@Bukhtawar
Copy link
Collaborator

Thanks for pointing this out @reta I missed the EnginePlugin interface that is exposed. But I would also doubt if there exists any implementation. I can do a quick scan on Github to see if there exists one

@Bukhtawar Bukhtawar closed this Jul 5, 2022
@satyajitg28 satyajitg28 mentioned this pull request Jul 8, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bukhtawar @reta