Changes to encapsulate Translog into TranslogManager #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Bukhtawar
changed the title
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
changed the title
sachinpkale
reviewed
Jul 4, 2022
server/src/main/java/org/opensearch/index/translog/InternalTranslogManager.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/translog/InternalTranslogManager.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
|
/cc: @reta request to to please share your review on this PR |
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
Jul 4, 2022
| } | ||
| } finally { | ||
| IOUtils.close(replicaEngine, storeReplica, engine, store, () -> terminate(threadPool)); | ||
| } | ||
| } | ||
|
|
||
| protected void assertEngineCleanedUp(Engine engine, Translog translog) throws Exception { | ||
| protected InternalTranslogManager assertAndGetInternalTranslogManager(final TranslogManager translogManager) { |
There was a problem hiding this comment.
Please use JUnit assertions:
protected InternalTranslogManager assertAndGetInternalTranslogManager(final TranslogManager translogManager) {
assertThat(translogManager, instanceOf(InternalTranslogManager.class));
return (InternalTranslogManager) translogManager;
}
sachinpkale
reviewed
Jul 5, 2022
test/framework/src/main/java/org/opensearch/index/engine/EngineTestCase.java
Outdated
Show resolved
Hide resolved
sachinpkale
approved these changes
Jul 5, 2022
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
reta
approved these changes
Jul 5, 2022
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
5 tasks
sachinpkale
pushed a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jan 9, 2023
…ect#3751) * Changes to encapsulate Translog into TranslogManager Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bukhtawar Khan bukhtawa@amazon.com
Description
[Describe what this change achieves]
Issues Resolved
#3709
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.