Revert "Support task resource tracking in OpenSearch" #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
revert-2639-resource-tracker-integration
branch
from
9d764b6
to
a863800
Compare
5 tasks
reta
approved these changes
Apr 22, 2022
kotwanikunal
approved these changes
Apr 22, 2022
|
❌ Gradle Check failure 9d764b6605ac1c7f22d6021b20d3dc7c9aabbe7d |
|
❌ Gradle Check failure a8638002600db6fa36388e57680d9401513f3c72 |
|
Depends on #3042 |
nknize
force-pushed
the
revert-2639-resource-tracker-integration
branch
from
a863800
to
52e1c57
Compare
This reverts commit 6517eec. Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
force-pushed
the
revert-2639-resource-tracker-integration
branch
from
52e1c57
to
156208f
Compare
|
Just rebased. I often forget I have to add my sign-off due to gpg signing. An added layer of security I really like but not that friendly w/ our DCO check. I'd really love to explore gpg sign-off as an added requirement for the project that adds extra security auditing w/o ridiculous overhead for new contributors. |
nknize
approved these changes
Apr 22, 2022
|
Last 2 PRs are successful as well, without a revert:
Let's hold on (if there are no issues right now) till @tushar-kharbanda72 takes a look at the failures? |
nknize
requested changes
Apr 22, 2022
There was a problem hiding this comment.
Holding on revert until @tushar-kharbanda72 takes a look at the failures.
This was referenced Apr 25, 2022
nknize
approved these changes
Apr 25, 2022
This was referenced Apr 25, 2022
5 tasks
ketanv3
added a commit
to ketanv3/OpenSearch
that referenced
this pull request
Jul 31, 2022
Reopens changes from opensearch-project#2639 (reverted in opensearch-project#3046) to add a framework for task resource tracking. Currently, SearchTask and SearchShardTask support resource tracking but it can be extended to any other task. Changes since opensearch-project#2639: * Replaced the usage of AutoQueueAdjustingExecutorBuilder with ResizableExecutorBuilder * Resolved merge conflicts * Fixed broken tests Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Bukhtawar
pushed a commit
that referenced
this pull request
Aug 2, 2022
* Support task resource tracking in OpenSearch * Reopens changes from #2639 (reverted in #3046) to add a framework for task resource tracking. Currently, SearchTask and SearchShardTask support resource tracking but it can be extended to any other task. * Fixed a race-condition when Task is unregistered before its threads are stopped * Improved error handling and simplified task resource tracking completion listener * Avoid registering listeners on already completed tasks Signed-off-by: Ketan Verma <ketan9495@gmail.com>
ketanv3
added a commit
to ketanv3/OpenSearch
that referenced
this pull request
Aug 2, 2022
* Support task resource tracking in OpenSearch * Reopens changes from opensearch-project#2639 (reverted in opensearch-project#3046) to add a framework for task resource tracking. Currently, SearchTask and SearchShardTask support resource tracking but it can be extended to any other task. * Fixed a race-condition when Task is unregistered before its threads are stopped * Improved error handling and simplified task resource tracking completion listener * Avoid registering listeners on already completed tasks Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Bukhtawar
pushed a commit
that referenced
this pull request
Aug 2, 2022
* [Backport 2.x] Support task resource tracking in OpenSearch * Reopens changes from #2639 (reverted in #3046) to add a framework for task resource tracking. Currently, SearchTask and SearchShardTask support resource tracking but it can be extended to any other task. * Fixed a race-condition when Task is unregistered before its threads are stopped * Improved error handling and simplified task resource tracking completion listener * Avoid registering listeners on already completed tasks Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2639 given build break failures.
@tushar-kharbanda72