[2.x] Revert "Make High-Level-Rest-Client tests allow deprecation warning temporarily (#2702)" #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emporarily, during deprecation of request parameter 'master_timeout' (opensearch-project#2702)" This reverts commit 6a2a33d. Signed-off-by: Tianli Feng <ftianli@amazon.com>
…recationmode Signed-off-by: Tianli Feng <ftianli@amazon.com>
11 tasks
mch2
approved these changes
Apr 16, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR can only be merged after PR #2920 merged. [<- achieved]
This reverts commit 6a2a33d, and will be get into
2.xbranch.This PR sets the High-Level-Rest-Client tests back to treating warning header as a failure.
During the process of deprecating REST API request parameter
master_timeoutand add alternative parametercluster_manager_timeout, I made High-Level-Rest-Client tests allow deprecation warning temporarily, by changing the argument ofsetStrictDeprecationMode()tofalsewhen buildingRestClientfor tests, in the above commit / PR #2702.Now it's decided not to emit deprecation warning for using parameter
master_timeoutin version 2.x, in issue #2928, so it will be ready to change this testing behavior back after PR #2920 merged.Testing:
./gradlew ':client:rest-high-level:asyncIntegTest'passed.Issues Resolved
A part of issue #2928 and issue #2511
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.