Allow the deprecation warning of the REST API request parameter 'master_timeout' for the requests sent by High Level REST Client #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter 'master_timeout' to HTTP response header Signed-off-by: Tianli Feng <ftianli@amazon.com>
tlfeng
force-pushed
the
skip-master-timeout-warning-header
branch
from
c7fa494
to
5f5bcba
Compare
Signed-off-by: Tianli Feng <ftianli@amazon.com>
tlfeng
added
v2.0.0
|
❌ Gradle Check failure c7fa494c5e30ddeea632c658a7eab8daa2d72fce |
5 tasks
Signed-off-by: Tianli Feng <ftianli@amazon.com>
tlfeng
force-pushed
the
skip-master-timeout-warning-header
branch
from
309e20f
to
b0d588e
Compare
tlfeng
changed the title
|
❌ Gradle Check failure 309e20fbfab796c1f0aceea515a959888bf8c2f5 |
Signed-off-by: Tianli Feng <ftianli@amazon.com>
tlfeng
removed
backport 2.x
|
Only allow the deprecation warning in HLRC has got a defect that a deprecation warning will still be logged in file of the server (logs directory). It will confuse the user, because they didn't use the parameter actively. The problem will be addressed in PR #2920 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The REST API request parameter 'master_timeout' is deprecated in issue #2511.
The PR allows the specific deprecation warning when Requests are sent by High Level REST Client.
In High Level REST Client, parameter 'master_timeout' is added to every applicable REST API call,
see org.opensearch.client.RequestConverters.Params.withMasterTimeout(TimeValue).
To keep the compatibility of Rest Client 2.x with server 1.x, the parameter 'master_timeout' is preserved.
The deprecated parameter is not actively used by the user, so allow the deprecation warning by default.
Issues Resolved
A part of #2511
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.