Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Update ThirdPartyAuditTask to check for and list pointless exclusions. #2764

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[Backport 2.x] Update ThirdPartyAuditTask to check for and list pointless exclusions. #2764

merged 1 commit into from
Apr 5, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 21f9950 from #2760

@mch2 @github-actions
Update ThirdPartyAuditTask to check for and list pointless exclusions. (
3f9fd2f 
#2760)

This change swaps the order of the task to first check for no pointless exclusions.
If not caught first these will be thrown inside of the bogusExcludesCount block that logs a
useless error message.

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 21f9950)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner April 5, 2022 04:19
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 3f9fd2f
Log 4184

Reports 4184

@nknize
Copy link
Collaborator

nknize commented Apr 5, 2022

another #1703

refiring

@nknize
Copy link
Collaborator

nknize commented Apr 5, 2022

start gradle check

@nknize nknize added Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request v2.1.0 Issues and PRs related to version 2.1.0 labels Apr 5, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 3f9fd2f
Log 4187

Reports 4187

@nknize nknize merged commit 55726d4 into 2.x Apr 5, 2022
@github-actions github-actions bot deleted the backport/backport-2760-to-2.x branch April 5, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

Assignees
No one assigned
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opensearch-ci-bot @nknize @mch2