Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace blacklist in Gradle build environment configuration #2752

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Apr 4, 2022

Description

Replace the system property name tests.rest.blacklist that used for skipping some of the YAML-based REST tests in gradle task.

  • Replace blacklist with denylist in all tests.rest.blacklist and REST_TESTS_BLACKLIST

Issues Resolved

Resolve #2458

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request v2.1.0 Issues and PRs related to version 2.1.0 backport 2.x Backport to 2.x branch labels Apr 4, 2022
@tlfeng tlfeng requested a review from a team as a code owner April 4, 2022 20:34
@tlfeng tlfeng added the v3.0.0 Issues and PRs related to version 3.0.0 label Apr 4, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4ac9dc6
Log 4147

Reports 4147

@tlfeng
Copy link
Collaborator Author

tlfeng commented Apr 4, 2022

In log 4147:

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.cluster.coordination.JoinTaskExecutorTests.testPreventJoinClusterWithUnsupportedNodeVersions" -Dtests.seed=445AF7CCE2D6222A -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=vi-VN -Dtests.timezone=Asia/Vladivostok -Druntime.java=17

org.opensearch.cluster.coordination.JoinTaskExecutorTests > testPreventJoinClusterWithUnsupportedNodeVersions FAILED
    junit.framework.AssertionFailedError: Expected exception IllegalStateException but no exception was thrown
        at __randomizedtesting.SeedInfo.seed([445AF7CCE2D6222A:C72550B63015B266]:0)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2898)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2884)
        at org.opensearch.cluster.coordination.JoinTaskExecutorTests.testPreventJoinClusterWithUnsupportedNodeVersions(JoinTaskExecutorTests.java:122)

It's reproducible in main branch. Seems related to PR #2722 / commit 2d716ad .
Update: after the commit cb238aa / PR #2556 merged, main branch is bumped to version 3.0.0, the test failure seems to be fixed.

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure ce57ddb
Log 4160

Reports 4160

@tlfeng
Copy link
Collaborator Author

tlfeng commented Apr 4, 2022

In log 4160:

> Task :qa:mixed-cluster:v2.1.0#mixedClusterTest

REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v2.1.0#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=tasks.list/10_basic/tasks_list test}" -Dtests.seed=E341A5CF2EF8EBC0 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-PE -Dtests.timezone=America/Belem -Druntime.java=17

org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=tasks.list/10_basic/tasks_list test} FAILED
    java.lang.AssertionError: Failure at [tasks.list/10_basic:15]: field [nodes.$node_id.roles] doesn't have a true value
    Expected: not null
         but: was null
        at __randomizedtesting.SeedInfo.seed([E341A5CF2EF8EBC0:6B159A1580048638]:0)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.executeSection(OpenSearchClientYamlSuiteTestCase.java:454)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.test(OpenSearchClientYamlSuiteTestCase.java:427)

It's reported in issue #2757. Also seen in issue #2660 (comment).

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success b2afd3c
Log 4175

Reports 4175

@tlfeng tlfeng added Build Libraries & Interfaces v2.0.0 Version 2.0.0 backport 2.0 Backport to 2.0 branch and removed v2.1.0 Issues and PRs related to version 2.1.0 labels Apr 5, 2022
@tlfeng tlfeng merged commit ed040e9 into opensearch-project:main Apr 6, 2022
@tlfeng tlfeng deleted the replace-gradle-blacklist branch April 6, 2022 00:48
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 6, 2022
- Replace `blacklist` with `denylist` in all `tests.rest.blacklist` and `REST_TESTS_BLACKLIST`
Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit ed040e9)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 6, 2022
- Replace `blacklist` with `denylist` in all `tests.rest.blacklist` and `REST_TESTS_BLACKLIST`
Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit ed040e9)
tlfeng pushed a commit that referenced this pull request Apr 6, 2022
…2780)

- Replace `blacklist` with `denylist` in all `tests.rest.blacklist` and `REST_TESTS_BLACKLIST`

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit ed040e9)
tlfeng pushed a commit that referenced this pull request Apr 6, 2022
…2781)

- Replace `blacklist` with `denylist` in all `tests.rest.blacklist` and `REST_TESTS_BLACKLIST`

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit ed040e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request v2.0.0 Version 2.0.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "blacklist / whitelist" terminology in Gradle build environment configuration
4 participants