Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove include_type_name parameter from rest api spec #2410

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Remove include_type_name parameter from rest api spec #2410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions rest-api-spec/src/main/resources/rest-api-spec/api/indices.create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@
]
},
"params":{
"include_type_name":{
"type":"boolean",
"description":"Whether a type should be expected in the body of the mappings."
},
"wait_for_active_shards":{
"type":"string",
"description":"Set the number of active shards to wait for before the operation returns."
Expand Down
4 changes: 0 additions & 4 deletions rest-api-spec/src/main/resources/rest-api-spec/api/indices.get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@
]
},
"params":{
"include_type_name":{
"type":"boolean",
"description":"Whether to add the type name to the response (default: false)"
},
"local":{
"type":"boolean",
"description":"Return local information, do not retrieve the state from master node (default: false)"
Expand Down
4 changes: 0 additions & 4 deletions rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_field_mapping.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
]
},
"params":{
"include_type_name":{
"type":"boolean",
"description":"Whether a type should be returned in the body of the mappings."
},
"include_defaults":{
"type":"boolean",
"description":"Whether the default mapping values should be returned as well"
Expand Down
4 changes: 0 additions & 4 deletions rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@
]
},
"params":{
"include_type_name":{
"type":"boolean",
"description":"Whether a type should be returned in the body of the mappings."
},
"flat_settings":{
"type":"boolean",
"description":"Return settings in flat format (default: false)"
Expand Down
4 changes: 0 additions & 4 deletions rest-api-spec/src/main/resources/rest-api-spec/api/indices.put_template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@
]
},
"params":{
"include_type_name":{
"type":"boolean",
"description":"Whether a type should be returned in the body of the mappings."
},
"order":{
"type":"number",
"description":"The order for this template when merging multiple matching ones (higher numbers are merged later, overriding the lower numbers)"
Expand Down
4 changes: 0 additions & 4 deletions rest-api-spec/src/main/resources/rest-api-spec/api/indices.rollover.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
]
},
"params":{
"include_type_name":{
"type":"boolean",
"description":"Whether a type should be included in the body of the mappings."
},
"timeout":{
"type":"time",
"description":"Explicit operation timeout"
Expand Down
3 changes: 1 addition & 2 deletions server/src/main/java/org/opensearch/rest/action/admin/indices/RestGetFieldMappingAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
import static org.opensearch.rest.RestStatus.OK;

public class RestGetFieldMappingAction extends BaseRestHandler {

private static final Logger logger = LogManager.getLogger(RestGetFieldMappingAction.class);
private static final DeprecationLogger deprecationLogger = DeprecationLogger.getLogger(logger.getName());

Expand Down Expand Up @@ -107,7 +106,7 @@ public RestResponse buildResponse(GetFieldMappingsResponse response, XContentBui
status = NOT_FOUND;
}
response.toXContent(builder, request);
return new BytesRestResponse(RestStatus.OK, builder);
return new BytesRestResponse(status, builder);
}
});
}
Expand Down