Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point In Time Search POC #1652

Closed
wants to merge 1 commit into from
Closed

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Dec 3, 2021

Signed-off-by: Surya Sashank Nistala snistala@amazon.com

Description

Adds point in time search APIs.

Issues Resolved

#1147

Check List

  • [] New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep requested a review from a team as a code owner December 3, 2021 13:48
@eirsep eirsep marked this pull request as draft December 3, 2021 13:49
@eirsep eirsep changed the title Point In Time Search POC [WIP] Point In Time Search POC Dec 3, 2021
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 4a4efc6

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 4a4efc6
Log 1692

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4a4efc6
Log 1315

Reports 1315

@dblock
Copy link
Member

dblock commented Dec 3, 2021

Maybe we can get a look at this from @Bukhtawar @shwetathareja @nknize @reta ...

@reta
Copy link
Collaborator

reta commented Dec 3, 2021

@dblock yep, but it is still in draft stage, may be we could just wait a bit, there are many TODO items, wdyt?

@dblock
Copy link
Member

dblock commented Dec 3, 2021

@dblock yep, but it is still in draft stage, may be we could just wait a bit, there are many TODO items, wdyt?

For sure. Just as long as we have some 👀

@shwetathareja
Copy link
Member

@reta @dblock: sorry, missed this earlier. will take a look. thanks.

@dblock
Copy link
Member

dblock commented Mar 29, 2022

Let's move this one forward?

@eirsep
Copy link
Member Author

eirsep commented Apr 2, 2022

We have a feature branch opened for this.
Will be incrementally pushing code to that branch. Makes it easier to review.

Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants