Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add support for async deletion in S3BlobContainer (#15621) #16013

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[Backport 2.x] Add support for async deletion in S3BlobContainer (#15621) #16013

wants to merge 1 commit into from

Conversation

ashking94
Copy link
Member

Backport 2b670cc from #15621.

@ashking94
Add support for async deletion in S3BlobContainer (opensearch-project…
b810ec8 
…#15621)

* Add support for async deletion in S3BlobContainer

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Move helper methods to helper class

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Minor refactor

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add UTs

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add more tests

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Integrate async deletion in the snapshot interactions

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b810ec8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 20, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b810ec8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Sep 20, 2024
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for b810ec8: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 82.96296% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.58%. Comparing base (448ae5e) to head (b810ec8).
Report is 5 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ch/repositories/blobstore/BlobStoreRepository.java 42.85% 14 Missing and 2 partials ⚠️
...bstore/AsyncMultiStreamEncryptedBlobContainer.java 0.00% 4 Missing ⚠️
...rg/opensearch/repositories/s3/S3BlobContainer.java 97.01% 1 Missing and 1 partial ⚠️
...rch/repositories/s3/async/S3AsyncDeleteHelper.java 97.14% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16013      +/-   ##
============================================
- Coverage     71.77%   71.58%   -0.20%     
+ Complexity    64687    64629      -58     
============================================
  Files          5277     5278       +1     
  Lines        302344   302476     +132     
  Branches      43993    44002       +9     
============================================
- Hits         217003   216521     -482     
- Misses        67223    67840     +617     
+ Partials      18118    18115       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashking94 @gbbafna