[SnapshotV2] Version change to V_2.17.0 for node min version check in create snapshot V2 #15644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
anshu1106
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
anshu1106
force-pushed
the
create-version-2
branch
from
872aee6
to
230a358
Compare
|
❌ Gradle check result for 872aee6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15644 +/- ##
============================================
- Coverage 72.00% 71.78% -0.22%
+ Complexity 64149 64002 -147
============================================
Files 5269 5269
Lines 299834 299867 +33
Branches 43330 43340 +10
============================================
- Hits 215895 215269 -626
- Misses 66217 66870 +653
- Partials 17722 17728 +6 ☔ View full report in Codecov by Sentry. |
sachinpkale
approved these changes
Sep 4, 2024
|
❌ Gradle check result for f7a2df4: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
anshu1106
force-pushed
the
create-version-2
branch
from
f7a2df4
to
3e9c253
Compare
|
❌ Gradle check result for 3e9c253: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
|
❌ Gradle check result for 253abcc: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
|
❌ Gradle check result for 7529554: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 7529554: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sachinpkale
approved these changes
Sep 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Co-authored-by: Anshu Agarwal <anshukag@amazon.com> (cherry picked from commit 73e14ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Co-authored-by: Anshu Agarwal <anshukag@amazon.com> (cherry picked from commit 73e14ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
that referenced
this pull request
Sep 5, 2024
(cherry picked from commit 73e14ab) Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
3 tasks
sachinpkale
pushed a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Sep 6, 2024
…ject#15644) Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Co-authored-by: Anshu Agarwal <anshukag@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
added a commit
that referenced
this pull request
Sep 6, 2024
* Mute test testRemoteStoreCleanupForDeletedIndexForSnapshotV2 (#15695) Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Mute flaky test RemoteFsTimestampAwareTranslogTests.testSimpleOperationsUpload (#15732) Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> * Mute failing snapshot status tests (#15652) Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com> * Restore snapshot changes for shallow snapshot V2 (#15462) --------- Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> * version change to V_2.17.0 for node min version check (#15644) Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Co-authored-by: Anshu Agarwal <anshukag@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com> Signed-off-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com> Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Co-authored-by: Marc Handalian <marc.handalian@gmail.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com> Co-authored-by: Gaurav Bafna <gbbafna@amazon.com> Co-authored-by: Anshu Agarwal <anshuagarwal11@gmail.com> Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
This was referenced Sep 6, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…ject#15644) Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes min node version check to V_2.17.0 in create snapshot v2.
Related Issues
Resolves #15123
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.