Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Star tree] Star tree index validations #15533

Merged
merged 13 commits into from
Sep 3, 2024

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Aug 30, 2024

Description

  • Limit the maximum number of base metrics to 100 with 2.17 experimental release.
  • Limit the index.translog.flush_threshold_size to maximum of 512 mb which is the default value of final setting indices.composite_index.translog.max_flush_threshold_size. Since flush is heavy for star tree index, limiting the maximum number of documents during flush will help with the indexing throughput.
  • For documents with array values - currently star tree index cannot handle such cases, since 'star' property does not get satisfied.

Related Issues

Resolves #15491

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 62a0267: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 21cf04f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15533-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0512e9ee74a3a8929bbaa3c415cca6ca49791585
# Push it to GitHub
git push --set-upstream origin backport/backport-15533-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15533-to-2.x.

@bharath-techie bharath-techie added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch backport-failed labels Sep 3, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15533-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0512e9ee74a3a8929bbaa3c415cca6ca49791585
# Push it to GitHub
git push --set-upstream origin backport/backport-15533-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15533-to-2.x.

bharath-techie added a commit to bharath-techie/OpenSearch that referenced this pull request Sep 3, 2024
---------

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
gbbafna pushed a commit that referenced this pull request Sep 4, 2024
---------

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
---------

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
(cherry picked from commit 5875393)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bharath-techie added a commit to bharath-techie/OpenSearch that referenced this pull request Sep 4, 2024
sachinpkale pushed a commit that referenced this pull request Sep 4, 2024
…) (#15676)

---------

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
---------

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Indexing:Performance skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Star tree validations
4 participants