Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote shards balance #15335

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bugmakerrrrrr
Copy link
Contributor

Description

see #15302

Related Issues

Resolves #15302

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for 229ab75: SUCCESS

Copy link
Contributor

❕ Gradle check result for bd3a94b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (01184de) to head (bd3a94b).
Report is 1 commits behind head on main.

Files Patch % Lines
...ing/allocation/allocator/RemoteShardsBalancer.java 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main   #15335    +/-   ##
==========================================
  Coverage     71.84%   71.85%            
- Complexity    63164    63183    +19     
==========================================
  Files          5214     5214            
  Lines        295937   295942     +5     
  Branches      42754    42756     +2     
==========================================
+ Hits         212606   212639    +33     
+ Misses        65907    65797   -110     
- Partials      17424    17506    +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross added the backport 2.x Backport to 2.x branch label Aug 21, 2024
@sohami
Copy link
Collaborator

sohami commented Aug 30, 2024

@bugmakerrrrrr Can you please fix the change log conflict

Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: panguixin <panguixin@bytedance.com>
@bugmakerrrrrr
Copy link
Contributor Author

@bugmakerrrrrr Can you please fix the change log conflict

@sohami done

Copy link
Contributor

❌ Gradle check result for 40bcd07: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Search:Searchable Snapshots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RemoteShardsBalancer cannot rebalance shards as expected
3 participants